fix(installer): accept current Station resume receipts

[senthilr-nv]

Summary

Station Express host preparation writes a six-field resume receipt, but onboarding accepted only the legacy three-field format. This caused a physical Station E2E on merged main to exit during final receipt retirement; the parser now accepts and validates both formats.

Changes

• Accept the current installer receipt fields for agent, sandbox, and policy tier while preserving legacy receipt compatibility.
• Keep receipt parsing fail-closed by validating every current field and rejecting unknown agents, invalid sandbox names, invalid policy tiers, extra lines, and malformed core fields.
• Add a cross-contract regression that writes the receipt through the shell installer and validates it through the TypeScript retirement boundary.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: this restores the documented Station resume flow and changes only validation of the private installer receipt; the documentation review found no inaccurate user-facing guidance.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: local fail-closed review confirmed that both accepted formats validate revision, model, and generation; the current format additionally validates agent, sandbox, and policy tier, with negative regression coverage.
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project cli src/lib/onboard/station-express-resume.test.ts (43 passed); npx vitest run --project installer-integration test/install-station-host-preparation.test.ts (55 passed); npm run typecheck:cli passed.
• Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Senthil Ravichandran senthilr@nvidia.com

Summary by CodeRabbit

• New Features

  • Added support for resuming Station Express installation from the current receipt format, including agent, sandbox, and policy tier details.
  • Continued support for legacy installer resume receipts.

• Bug Fixes

  • Improved validation of installer resume data, rejecting unsupported or malformed values while preserving the receipt for troubleshooting.

• Tests

  • Added coverage for accepting and retiring valid receipts, rejecting invalid receipts, and validating resume state after a required reboot.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 285765ce-c7ca-4974-9192-2dbb5dae33dd

📥 Commits

Reviewing files that changed from the base of the PR and between 6e60cc8 and f5dd979.

📒 Files selected for processing (3)

• src/lib/onboard/station-express-resume.test.ts
• src/lib/onboard/station-express-resume.ts
• test/install-station-host-preparation.test.ts

---

📝 Walkthrough

Walkthrough

Station Express resume parsing now supports and validates current installer receipts while retaining legacy format support. Tests cover valid and invalid receipt metadata, retirement behavior, receipt preservation, and resume-state validation after reboot-required host preparation.

Changes

Station Express resume validation

Layer / File(s)	Summary
Current receipt format parsing src/lib/onboard/station-express-resume.ts	Adds allowlists and validates the current seven-line receipt format while preserving support for the legacy four-line format.
Receipt validation and integration tests src/lib/onboard/station-express-resume.test.ts, test/install-station-host-preparation.test.ts	Tests valid and invalid current receipts, retirement and preservation behavior, and resume-state validation after host preparation requires a reboot.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• NVIDIA/NemoClaw#7126: Extends related Station Express resume receipt handling and metadata validation.

Suggested labels: bug-fix, area: install, platform: dgx-station

Suggested reviewers: jyaunches

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: supporting current Station resume receipts while keeping installer behavior context.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Model comparison: normalized findings match; normalized E2E selections differ; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

Since last review: 0 prior items resolved · 0 still apply · 0 new items found

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: onboard-repair, onboard-resume, cloud-onboard

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.