Skip to content

chore(ci): remove merged PR 12767 budget exception - #13034

Merged
prekshivyas merged 1 commit into
mainfrom
codex/12767-remove-expired-budget-exception
Oct 12, 2026
Merged

prekshivyas merged 1 commit into
mainfrom
codex/12767-remove-expired-budget-exception

Conversation

@rsliter

@rsliter rsliter commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Outcome

Remove the expired assertion-budget exception for merged PR #12767.

Reason

The exception explicitly requires removal after #12767 merges. That PR merged on October 9, 2026.

Related issues

Refs #12767.

Changes

Remove the PR #12767 entry and its explanatory paragraph from ci/e2e-assertion-growth-exceptions.json. Preserve all seven other entries and the assertion budget.

Verification

  • npx --no-install vitest run --project integration test/automation/pull-requests/growth-guardrail-parsers.test.ts test/automation/pull-requests/growth-guardrails.test.ts: 65 tests passed.
  • Semantic comparison with canonical main: exactly one entry and its paragraph removed; other exceptions and the assertion budget unchanged.
  • git diff --check: passed.
  • Policy-only cleanup; no product behavior or live E2E coverage changed.
  • Reviewed the diff: no secrets, API keys, or credentials.

Signed-off-by: Rebecca Sliter 571084+rsliter@users.noreply.github.com

Summary by CodeRabbit

  • Chores
    • Updated release validation rules. No changes to user-facing features or behavior.

Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/NemoClaw/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 18181ea5-17c7-49b0-a026-1c3e42b3fd92

📥 Commits

Reviewing files that changed from the base of the PR and between 639a4c6 and f5768e4.


📒 Files selected for processing (1)
  • ci/e2e-assertion-growth-exceptions.json

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.



📝 Walkthrough
📝 Walkthrough

Walkthrough

The assertion-growth exception policy now documents PR #12958 approval and transition details. It also removes the PR #12767 exception and its associated budget digests.

Changes

Assertion exception policy

Layer / File(s) Summary
Update exception policy
ci/e2e-assertion-growth-exceptions.json
The comment records PR #12958 approval, static-hook scope, continued GitHub verification, and removal after merge. The PR #12767 exception and its base and head budget digests are removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: deepujain


Merge Risk: ⚪ Minimal · up to f5768

This removes the exception for the specific PR #12767 budget transition while leaving the guard and other exceptions intact. No concrete merge-blocking risk remains.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the merged PR #12767 budget exception from CI configuration.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@rsliter

rsliter commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@github-code-quality

github-code-quality Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit f5768e4 in the codex/12767-remove-e... branch is 97%. The line coverage in commit 63002cd in the main branch is 96%.

Show a line coverage summary of the most impacted files.
File main 63002cd codex/12767-remove-e... f5768e4 +/-
nemoclaw/src/onboard/config.ts 98% 96% -2%
nemoclaw/src/index.ts 94% 93% -1%
nemoclaw/src/bl...print/runner.ts 95% 95% 0%
nemoclaw/src/bl...ime-identity.ts 97% 97% 0%
nemoclaw/src/bl...t-management.ts 100% 100% 0%
nemoclaw/src/co.../config-show.ts 100% 100% 0%
nemoclaw/src/commands/slash.ts 100% 100% 0%
nemoclaw/src/on...native-route.ts 0% 100% +100%

TypeScript / code-coverage/cli

The overall line coverage in commit f5768e4 in the codex/12767-remove-e... branch is 86%. The line coverage in commit 63002cd in the main branch is 84%.

Show a line coverage summary of the most impacted files.
File main 63002cd codex/12767-remove-e... f5768e4 +/-
src/lib/onboard.ts 62% 47% -15%
src/lib/actions...ess-recovery.ts 65% 78% +13%
src/lib/state/l...diness-lease.ts 66% 82% +16%
src/lib/inferen...ollama/proxy.ts 41% 61% +20%
src/lib/onboard.../application.ts 55% 84% +29%
src/lib/domain/...y/dimensions.ts 0% 71% +71%
src/lib/actions...try/snapshot.ts 0% 73% +73%
src/lib/actions...ry/operation.ts 0% 76% +76%
src/lib/inferen...ovider/index.ts 0% 88% +88%
src/lib/onboard...ternal-image.ts 0% 91% +91%

Updated October 12, 2026 13:22 UTC

@github-actions

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit f5768e4. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

Request review only when Require no Advisor blockers is green.

All previous runs

@rsliter

rsliter commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

For commit f5768e439b80cd5b553c8cb973d2b71815abe6c9, all nine Advisor specialists reported no findings and recommended no additional E2E jobs or targets, including optional selections. The deterministic plan also requires none for this policy-only cleanup. No live E2E was dispatched. CI passed; 65 focused policy tests passed locally.

@rsliter
rsliter marked this pull request as ready for review October 12, 2026 13:30
@prekshivyas
prekshivyas merged commit bc4f3b4 into main Oct 12, 2026
76 checks passed
@prekshivyas
prekshivyas deleted the codex/12767-remove-expired-budget-exception branch October 12, 2026 22:42
@wscurran wscurran added area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants