Skip to content

chore(ci): remove merged model-drift budget exception - #12933

Merged
prekshivyas merged 1 commit into
mainfrom
codex/12667-budget-cleanup
Oct 9, 2026
Merged

prekshivyas merged 1 commit into
mainfrom
codex/12667-budget-cleanup

Conversation

@rsliter

@rsliter rsliter commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Outcome

Remove the obsolete assertion-growth exception for merged PR #12769.

Reason

PR #12769 merged as 0754ac5. Its reviewed live assertions are now part of the main budget, so the temporary transition exception is no longer needed.

Related issues

Refs #12667. Follow-up to #12769 and the prerequisite policy renewal #12871.

Changes

Remove the #12769 exact digest pair and its explanatory paragraph from ci/e2e-assertion-growth-exceptions.json. Preserve the six other exception entries, the live assertion budget, and all test coverage.

Verification

  • Existing growth-guardrail parser suite: 58 tests passed.
  • Structural comparison: exactly the fix(onboard): check selection drift before fresh sandbox reuse #12769 entry and its paragraph were removed; all other policy values are unchanged.
  • Normal signed-commit hooks, publication validation, and CLI/plugin/JavaScript compiler checks: passed.
  • Reviewed the complete one-file change. It contains no secrets, API keys, or credentials.

Signed-off-by: Rebecca Sliter 571084+rsliter@users.noreply.github.com

Summary by CodeRabbit

  • Chores
    • Updated CI assertion-budget exception records, including refreshed approval and budget details.
    • Removed an existing exception; other exception records remain unchanged.

@rsliter rsliter self-assigned this Oct 9, 2026
@copy-pr-bot

copy-pr-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/NemoClaw/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 7e9b3a5b-68a1-4ce2-a6ef-5a5a6fffec88

📥 Commits

Reviewing files that changed from the base of the PR and between e63abc0 and 36a7094.


📒 Files selected for processing (1)
  • ci/e2e-assertion-growth-exceptions.json

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review.



📝 Walkthrough

Walkthrough

The E2E assertion-growth policy comment now records updated PR #12382 and PR #12777 details. The exception entry for PR #12769 was removed.

Changes

E2E assertion growth policy

Layer / File(s) Summary
Update exception policy
ci/e2e-assertion-growth-exceptions.json
The comment now documents PR #12382 approval details and PR #12777 budget accounting. The PR #12769 exception entry and its digests were removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: ericksoa


Merge Risk: ⚪ Minimal · up to 36a70

The PR removes an obsolete assertion-growth exception without changing the budget, which already includes the reviewed assertions. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the removal of a merged CI budget exception, which is the primary change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit 36a7094 in the codex/12667-budget-c... branch is 97%. The line coverage in commit 63002cd in the main branch is 96%.

Show a line coverage summary of the most impacted files.
File main 63002cd codex/12667-budget-c... 36a7094 +/-
nemoclaw/src/onboard/config.ts 98% 96% -2%
nemoclaw/src/index.ts 94% 93% -1%
nemoclaw/src/bl...print/runner.ts 95% 95% 0%
nemoclaw/src/bl...ime-identity.ts 97% 97% 0%
nemoclaw/src/bl...t-management.ts 100% 100% 0%
nemoclaw/src/co.../config-show.ts 100% 100% 0%
nemoclaw/src/commands/slash.ts 100% 100% 0%
nemoclaw/src/on...native-route.ts 0% 100% +100%

TypeScript / code-coverage/cli

The overall line coverage in commit 36a7094 in the codex/12667-budget-c... branch is 86%. The line coverage in commit 63002cd in the main branch is 84%.

Show a line coverage summary of the most impacted files.
File main 63002cd codex/12667-budget-c... 36a7094 +/-
src/lib/onboard.ts 62% 46% -16%
src/lib/onboard...rchestration.ts 41% 32% -9%
src/lib/state/sandbox.ts 92% 84% -8%
src/lib/actions...ess-recovery.ts 65% 78% +13%
src/lib/inferen...file/cleanup.ts 73% 88% +15%
src/lib/state/l...diness-lease.ts 66% 82% +16%
src/lib/inferen...ollama/proxy.ts 41% 61% +20%
src/lib/onboard.../application.ts 55% 84% +29%
src/lib/inferen...nvidia/index.ts 0% 85% +85%
src/lib/onboard...ternal-image.ts 0% 91% +91%

Updated October 09, 2026 18:53 UTC

@rsliter
rsliter marked this pull request as ready for review October 9, 2026 18:38
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit 36a7094. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

Request review only when Require no Advisor blockers is green.

All previous runs

@rsliter

rsliter commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator Author

Review and E2E disposition for 36a709428b899dcc3bd6a79e564b96dc0bcb733a:

  • CI passed.
  • PR Review Advisor passed. All nine specialists’ findings, summaries, and E2E recommendations were collected and read (27 receipts); no findings remain.
  • All nine specialists recommended no E2E jobs or targets for this policy-only removal. No live E2E was dispatched.

The exact commit is GitHub Verified and mergeable. Automated checks and reviews are clear; eligible human approval is still required.

@prekshivyas
prekshivyas merged commit 4dcb869 into main Oct 9, 2026
76 checks passed
@prekshivyas
prekshivyas deleted the codex/12667-budget-cleanup branch October 9, 2026 19:07
@wscurran wscurran added area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance labels Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI workflows, checks, release automation, or GitHub Actions area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants