Repository navigation
test(e2e): match Slack approvals to fixture workspace - #12873
Conversation
Pinned OpenClaw stores Slack approvals under team-qualified sender identities. The pairing fixture queried the raw sender and would reject successful approval. Use one explicit fixture team for Socket Mode events and the SQLite expectation. Preserve raw Discord identity checks and the existing live assertions. Validation: two SQLite cases failed before the correction, then all 44 pairing support tests passed. Upstream rebuild reconciliation passed 71 support tests. Live qualification remains pending. Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This change updates the Slack pairing E2E fixture to use the workspace-qualified approval identity and adds tests for it. It does not affect production behavior. Live qualification and hosted checks remain pending, but no actionable merge risk was found in the supplied code. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: matching Slack approvals to the fixture workspace. It is specific and consistent with the pull request changes.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
@coderabbitai review |
✅ Action performedReview finished.
|
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 5d2af86 in the Show a line coverage summary of the most impacted files.
Updated |
Integrate main at 82526e9. Preserve published PR history. The merge is conflict-free. Focused pairing support tests passed after integration.
The approval-only correction still failed in live E2E because the probe created a raw user request. Pinned Slack creates workspace-qualified requests and retains the raw sender in metadata. Match that contract before approval, and check the same qualified identity in pending and approved SQLite state. Four focused regressions failed before this correction. All 46 pairing support tests pass. Live Slack qualification remains pending.
Integrate main at bf8ab4f after the first repaired E2E run passed. Preserve the Slack pairing correction and published history. Requalify the resulting commit with the selected E2E jobs.
Integrate main at 1d90ed5 without rewriting published history. The added main changes affect separate inference-switch tests; preserve the qualified Slack pairing fixture.
wscurran
added
area: e2e
2 participants
Outcome
The Slack pairing E2E fixture creates and checks the same workspace-qualified identity as pinned OpenClaw. Pending requests and approved entries must match the fixture workspace; raw Slack identities and other workspaces are rejected. Discord keeps its raw sender identity.
Reason
The earlier approval-only correction still failed in E2E run 37887438352. The synthetic request used a raw user ID, while the pinned Slack plugin creates a workspace-qualified request. The CLI can approve the stored request without an active Slack adapter, leaving the raw identity unchanged. Changing only the expected approval value was insufficient.
Changes
1d90ed51690af23814689fe49b365171d3a73114without rewriting published history.Verification
Four focused regression cases failed before the correction; all 46 pairing support tests pass afterward.
A disposable pinned OpenClaw CLI reproduction stored the raw identity for the old request and the qualified identity for the corrected request. This is dependency evidence, not managed-image E2E qualification.
Normal commit hooks passed, including formatting, lint, repository checks, semantic phase plans, source-shape and growth checks, and secret scanning.
No secrets or credentials added.
Normal pre-push publication validation and CLI type checking passed; GitHub verified both new commits.
E2E run 38267782279 passed all selected jobs on
9b1497f575: Slack and Discord pairing, cloud onboarding, full E2E, and both security-posture variants. Slack and Discord state and cleanup artifacts were verified.Main advanced during that run. After merging its provider-timeout fix, all 53 pairing and provider-timeout tests passed. Normal publication checks passed and GitHub verified merge commit
279a7efd0ed15e4360574dd78661e833e4d6f928.Confirming E2E run 38270348970 passed on
279a7efd0ed15e4360574dd78661e833e4d6f928against main atbf8ab4f542649fb98ef4e98d025ebd3671a0468e. All six scenario jobs and Relevant E2E passed.Final Slack artifacts show qualified pending state, successful approval and allow-state lookup, repeated-approval rejection, and ten successful cleanup actions. All selected scenario cleanup reports have no failures.
After the latest main merge, all 125 pairing and inference-switch support tests passed. Normal publication checks passed, and GitHub verified the merge commit.
E2E run 38273434015 is running the same selected coverage on
5d2af86282b58cf70ce160a7d6587d3fa67fa2d9.Review notes
Advisor run 38266844476 completed all nine specialists with no code findings for
9b1497f575da9d0f8ef4b27a19dd3e8fc01c7bc7against82526e9566bb4b85304ca5d96d9ab90aa3e6b329. Its aggregate failed solely because migration-completion marked the Slack selector unresolved. The trusted manual planner accepts that selector, and the E2E run includes it. Specialist-based self-review completed using all nine trusted prompts and shared criteria, with no additional findings. This is not a passing Advisor aggregate or independent clearance for the fallback. The final merge preserves the same two-file PR diff byte-for-byte; specialist-based self-review was repeated against the new base after inspecting its timeout correction, with no new findings.The source audit accounts for request identity, adapter fallback, owner bootstrap, repeat approval, and cleanup. The selected live qualification passed for
279a7efd0ed15e4360574dd78661e833e4d6f928. Main later advanced to1d90ed51690af23814689fe49b365171d3a73114with separate inference-switch test changes. That commit is now merged as5d2af86282b58cf70ce160a7d6587d3fa67fa2d9. The PR diff remains byte-identical, and the specialist self-review was reapplied with no new findings. Runtime qualification of this latest merge is pending.Signed-off-by: Julie Yaunches jyaunches@nvidia.com