Repository navigation
Conversation
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
…se' into codex/12622-retained-gateway-reuse
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
Registration observation and registration can await while the declared gateway owner changes. Three regression cases reproduced registration or selection after that change. Reload the bound owner immediately before each registration and selection effect. Preserve registrations when authority changes so cleanup cannot mutate a different owner. Validation: 74 focused gateway runtime and observer tests pass. CLI type checking passes with an 8 GiB Node heap. Repaired Advisor finding F-security-built-in-quality-6daa530b0405f96b2753. Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Integrate main b769619, including the resumed OpenRouter inference repair in #12681, so the next exact-candidate Brev image includes that work. The merge had no conflicts. Validation: 112 focused gateway and OpenRouter CLI tests pass, plus four OpenRouter onboarding integration tests. The retained-gateway PR delta remains limited to 11 files. Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Registration metadata can remain after its gateway becomes unavailable. Carry the existing observer health result into the retained-gateway capture and require it after final cleanup. This addresses CodeRabbit review 5444316020 without changing lifecycle behavior or retries. Validation: 14 observer tests, the E2E assertion and semantic-phase checks, and CLI type checking pass. The real post-cleanup health observation remains pending trusted Brev E2E. Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Advisor found that post-registration authority drift retained a new local registration without identifying it or explaining recovery. Preserve the authority guard, report the registration name and inspection action, and recheck authority before publishing the selected gateway to the client. The recovery-message regression failed before the repair. A sibling selection-drift case exposed a missing final authority check and also failed before that check was added. All 75 runtime and observer tests now pass; CLI typecheck passes. No changed-owner cleanup or gateway destruction occurs. Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Integrate main through #12765 to accept verified dual SDK archives in trusted E2E installation. Preserve retained-gateway behavior and the required #12681 ancestry. Validation: 75 gateway runtime tests, 32 SDK installer tests, and 5 SDK package tests passed after the conflict-free merge. Brev SSH readiness remains unresolved and is not claimed as passing. Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pr-12854.docs.buildwithfern.com/nemoclaw |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 40ca6b0 in the Show a line coverage summary of the most impacted files.
|
|
Closing this do-not-merge comparison experiment. #12626 and #12826 have both merged, and the experiment answered its narrow question: NVIDIA onboarding passed. The full run (https://github.com/NVIDIA/NemoClaw/actions/runs/37835993189) subsequently failed at Launchable routing, addressed separately by merged brevdev/nemoclaw-image#202. Remaining Brev harness work belongs in #12907. |
Outcome
Temporary test candidate for the NVIDIA inference failure blocking #12626. This draft combines #12626 at
3d7e25fb805365ff3db4eda38df0e023ed5eb334with only the 31-file PR delta from #12826 at57ff4ca0fca1a85a8db53891a16fe8a3b188846f.Do not merge. Neither original PR branch nor main is changed. No newer main history was merged into this candidate.
Reason
The retained Brev run passed image creation, SSH access, and commit verification, then failed native NVIDIA onboarding verification with curl exit 56. This candidate tests whether the scoped native policy and supervisor-placeholder changes resolve that failure. The prior run did not retain a proxy response that establishes CONNECT 403 as its cause.
Related issues
Refs #12622, #12822. Temporary comparison of #12626 and #12826.
Changes
Verification
git diff --cached --check— passed before commit; exactly 31 files changed from fix(onboard): reuse retained gateway registration #12626.40ca6b0in run 37835993189. The baseline failed with curl exit 56. The full combined run failed afterward in Launchable routing; no full-suite pass is claimed.The narrow native NVIDIA onboarding comparison is complete. The full Brev suite currently assumes a global inference route that native NVIDIA setup deliberately does not create (
full-e2e.test.ts:1208-1260versussetup-inference.ts:968-1014). That is a separate harness blocker; no full-suite pass is claimed. The trusted full workflow supplied the narrow comparison. It failed after onboarding and before these stale assertions.Live comparison result
The isolated fix passed the previously failing native NVIDIA onboarding verification on the preserved #12626 baseline. Both runs used
nvidia-prodwithnvidia/nemotron-3-super-120b-a12b.3d7e25f: run 37801673014 failed native onboarding verification with curl exit 56.40ca6b0: run 37835993189 recorded healthy deployment verification and completed onboarding at 21:03:57 UTC. The success message requires the native sandbox invocation to return a successful HTTP status and an API-shaped response.brev-quickstartrouting step failed:selected sandbox agent does not match the requested route. The full E2E assertion atfull-e2e.test.ts:1103therefore failed. Later global-route assertions were not reached.40ca6b0a747204e22d6797e11fe8f70471b3e4da, clean baked checkout, no runtime overrides, image producer 37836564832, image repository37f6f7e5177753105b1a6bc2a7d324312645e2dc.nclaw-e2e-37835993189-1(6hdmi5ye1) was deleted and confirmedABSENTat 21:06:22 UTC. Retained evidence includes the child log, identity checks, and cleanup record.Comparison limitation: the image repository advanced from
ae1af18af08d9297fc56c6b4ad35a1d9618dbaccto37f6f7e5177753105b1a6bc2a7d324312645e2dc. Its two changes cover terminal readiness and selected-sandbox routing. Routing runs after onboarding. This is evidence that the combined candidate passes the original probe, not a claim of fully controlled A/B testing or full qualification.General PR CI also reports an assertion-budget increase in
concurrent-gateway-ports.test.ts. That file is unchanged by the isolated 31-file fix. The temporary candidate remains unchanged and is not merge-ready.Review notes
Sensitive paths include
agents/langchain-deepagents-code/**,src/lib/inference/**, andsrc/lib/onboard/**in NVIDIA/NemoClaw. The combined commit received source inspection and the focused checks above; no independent local Advisor clearance exists for this combined tree. These paths remain awaiting independent review.The user authorized this temporary publication and the trusted comparison runs. The candidate is not submitted for merge readiness. The known foreign-placeholder validation and stale native-grant findings from #12826 remain outside this comparison's repair scope; a passing inference test cannot clear them.
Validation used the documented isolated alternative because the preserved baseline predates the canonical validation tooling. Candidate tree:
a42d1ab887a7d18f2b824b2364b3ccca361aa5d3; publication commit:40ca6b0a747204e22d6797e11fe8f70471b3e4da. Canonical validation tooling came fromcd95b77c26dac10ad02f2cde88de1c9436174d00, unchanged in refreshed main9966f01e83f2e17456e763dc778b1827f55a0c52.Repository JavaScript checks and tests ran as a non-root user in a task-owned Linux container, with no contributor home, credentials, provider key, or Docker socket mounted. Only the disposable validation copy received canonical manifests, Vitest configuration, and test helpers; publication source retains the approved baseline. Normal Git hooks remain enabled. Pinned canonical Mac Oxlint parses source with the canonical configuration because the Linux copy hit an allocator failure. The canonical TypeScript compiler also parsed a disposable source copy on the Mac after the Linux VM exhausted memory; it passed with the verified SDK declarations installed. Candidate-controlled validators are not claimed as independent evidence. The live evidence below supplements this local validation.
Signed-off-by: Julie Yaunches jyaunches@nvidia.com