fix(e2e): scope base publication lookup to eligible commits

[prekshivyas]

Superseded by merged #12790 (bdace1e9194faa1dec78481e2045870996df376d). The merged controller passed 139 focused tests and resolved the real PR #12380 publication in 38.45 seconds within its 300-second budget. Closing this duplicate prerequisite draft; full qualification continues on #12380 and #12382. The unpublished latency follow-up remains preserved locally and is not represented as merged or approved.

Outcome

The E2E base-image prerequisite finds eligible publications after the repository accumulates more than 1,000 main-branch workflow runs. It queries the already validated first-parent commits and retains the existing publication provenance checks.

Reason

Full E2E run 37698389663 failed before any test ran because its lookup exceeded the 10-page safety cap. The repository had 1,003 historical runs, while the required base commit had one successful publication. This trusted controller runs from main, so a fix only in an upgrade PR cannot unblock it.

Related issues

Refs #12380 and #12382.

Changes

• Add head_sha to each workflow-run query using the existing eligible history. Reject responses containing a different commit.
• Preserve complete pagination, duplicate detection, nearest-publication selection, publisher-job checks, attempt binding, and the shared request deadline.
• Reproduce the historical-run limit in a regression test and cover a mismatched query response. Adapt existing polling fixtures to the scoped queries and extract setup into a support fixture to retain the test-size and branching limits.

Verification

• vitest run --project e2e-support test/e2e/support/base-image-publication.test.ts test/e2e/support/base-image-publication-history.test.ts test/e2e/support/base-image-publication-workflow-boundary.test.ts: 139 tests passed under Node 24.18.1.
• Normal signed-commit and push hooks passed, including publication validation, growth guardrails and TypeScript checks.
• The new history-limit regression fails with the original implementation and passes with this fix.
• Read the complete failed prerequisite and aggregate logs; audited the affected controller and downstream gates. The failed run supplied no candidate runtime-test evidence.
• Reviewed the diff for secrets, API keys, and credentials; none are included.
• Live confirmation requires this controller change on main, followed by a new full E2E run.

Review notes

Self-review covers tools/e2e/base-image-publication.mts and its support test/fixture files in NVIDIA/NemoClaw at ac26ce8b75f26e61760c368329b0252c8f6adefa, based on canonical main 1f37cf8eaf1bf19578f09709023f56da54dcc722. The review traced eligible Git history, API pagination, publication provenance, polling deadlines, artifact consumers, and the aggregate failure path. The sensitive tools/e2e/ change awaits independent review; this draft does not claim approval or a waiver.

---

Signed-off-by: Prekshi Vyas prekshiv@nvidia.com

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit ac26ce8 in the fix/e2e-base-publica... branch is 97%. The line coverage in commit 63002cd in the main branch is 96%.

Show a line coverage summary of the most impacted files.

File	main 63002cd	fix/e2e-base-publica... ac26ce8	+/-
nemoclaw/src/onboard/config.ts	98%	96%	-2%
nemoclaw/src/index.ts	94%	93%	-1%
nemoclaw/src/bl...t-management.ts	100%	100%	0%
nemoclaw/src/co.../config-show.ts	100%	100%	0%
nemoclaw/src/commands/slash.ts	100%	100%	0%
nemoclaw/src/on...native-route.ts	0%	100%	+100%

TypeScript / code-coverage/cli

The overall line coverage in commit ac26ce8 in the fix/e2e-base-publica... branch is 85%. The line coverage in commit 63002cd in the main branch is 84%.

Show a line coverage summary of the most impacted files.

File	main 63002cd	fix/e2e-base-publica... ac26ce8	+/-
src/lib/actions.../status-text.ts	84%	46%	-38%
src/lib/state/sandbox.ts	92%	82%	-10%
src/lib/onboard...al-inference.ts	84%	90%	+6%
src/lib/policy/index.ts	71%	80%	+9%
src/lib/state/p...l-retirement.ts	79%	92%	+13%
src/lib/onboard.../application.ts	55%	72%	+17%
src/lib/inferen...nvidia/index.ts	0%	85%	+85%
src/lib/adapter...gnostics-cli.ts	0%	87%	+87%
src/lib/onboard...ternal-image.ts	0%	91%	+91%
src/lib/securit...ig-structure.ts	0%	98%	+98%

---

_{Updated October 07, 2026 23:21 UTC}

[github-actions]

PR Review Advisor finished for commit ac26ce8. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

Request review only when Require no Advisor blockers is green.

All previous runs