Repository navigation
feat(inference): prepare inactive Cobalt serving recipe - #12493
prekshivyas wants to merge 7 commits into
Conversation
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe change adds inactive Cobalt model, recipe, and Station preset declarations under staging. Documentation describes staging restrictions and activation requirements. Tests check catalog exclusion, disabled selection, resolution behavior, and materialized serving settings. ChangesCobalt staging
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable product or production risk is established in the supplied change context. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 622e429 in the Show a line coverage summary of the most impacted files.
TypeScript / code-coverage/cliThe overall line coverage in commit 622e429 in the Show a line coverage summary of the most impacted files.
Updated |
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Update at b317826: the harness-independent Cobalt recipe is published, still hidden and disabled. Normal publication hooks passed, commits are Verified, and CodeRabbit completed with no actionable findings (its test-helper docstring warning remains advisory). The reviewed-npm-audit job failed on existing Undici 8.10.0 advisories: https://github.com/NVIDIA/NemoClaw/actions/runs/36658803114/job/109708837880. The package manifests, lockfiles and audit inputs match canonical base 41b9d9f; this five-file Cobalt diff adds no dependencies. The separate repair is already tracked in #12507. No audit waiver, policy weakening, or unchanged-job rerun is requested here. Other CI is still running. The automatic Advisor requires a successful full PR CI run, so the old Advisor result does not cover this update. Keep this PR draft pending complete checks, fresh review evidence, and human approval. |
|
@coderabbitai review |
|
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Advisor disposition for commit Finding
All nine specialist reports from Advisor run 37059391401 were collected. The other eight reports are clear, including Verification evidence, which confirms the earlier missing-command-assertion finding is resolved. No additional E2E recommendation was recorded. CodeRabbit is clear, full CI and security passed, and the PR has no conflicts. No workflow or test relocation is warranted. The branch remains unchanged and draft because |
|
The configuration update accepted in #12492 is implemented locally, but it is not yet committed or pushed. This PR still points to Local validation passed: 67 focused tests, the documentation check (zero errors/two warnings), secret scan, source-shape budget, and growth guardrails. All seven Cobalt tests passed again after the formatter change. Normal commit hooks blocked publication at This inherited validation failure needs a separate maintainer decision. No hook was bypassed, receipt replaced, validation weakened, or unrelated hardware run started. Existing Pi activation PR #12396 proposes removing the candidate receipt mechanism; that unmerged change is not imported into Cobalt. |
|
Publication exception requested by Prekshi Vyas in the active task: "ignore it, push" after the inherited Pi receipt failure was reported. Authenticated account Scope: only the known Run the other 17 repository checks explicitly before the commit. Skip the aggregate repository-checks pre-commit hook for that commit only, retaining all other hooks and signing. Leave normal pre-push validation and hosted CI unchanged. This is not a CI waiver, merge approval, or authorization to change Pi. Report any new failure separately. |
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
Outcome
Prepare an inactive, harness-independent Cobalt recipe for one DGX Station. The staged configuration requires NVFP4 weights, three-token MTP, 49,152-token context, thinking enabled, and JSON tool calls. Cobalt remains absent from production discovery and disabled even when compiled separately.
Reason
Record the selected serving configuration before release activation. Keep confidential artifacts and release qualification outside the public staging change.
Related issues
Refs #12492. Its accepted October 6 scope includes this configuration update; activation and default selection remain deferred.
Changes
managed-inference/staging/cobalt.parallel_tool_calls: false. Requested output must fit the context and remain at most 8,192 tokens; the recipe does not enforce that client limit.5c3c3e9838c500c0c0c171f7d89375486ffc2c85to consume the updated dependency-pin validation helper. The PR diff remains limited to five Cobalt files.Verification
npx vitest run --project integration test/inference/managed/cobalt-staging.test.ts test/inference/managed/managed-inference-catalog-compiler.test.ts --project cli src/lib/inference/serving/host-local-vllm-selection.test.ts src/lib/inference/serving/vllm-host-local-lifecycle.test.ts src/lib/inference/serving/profile-list.test.ts— 67 tests passed across five files for the serving update. The latest commit changes only explanatory prose; existing command assertions cover the thinking default.npm run docs— passed again after the prose correction, zero errors and two warnings.git diff --check— passed.622e429af2c86f077345b1a8fb3ded73ffeec1de. No local-check exception was used for this commit. All seven PR commits are GitHub Verified.622e429af2c86f077345b1a8fb3ded73ffeec1de, including all twelve CLI shards and merged coverage.These checks verify deterministic staging and catalog behavior. They do not establish live qualification of the staged recipe. Artifact identity, revision, image/digest, template contents, and download sizes remain release bindings. The complete pinned runtime must supply the required reasoning/tool fix and template; an unpatched runtime is not qualified here.
Review notes
Sensitive paths:
managed-inference/staging/cobalt/**in NVIDIA/NemoClaw. Self-review covered the complete diff, fixed arguments, media restrictions, authentication, receipts, disabled selection, and release prerequisites.CodeRabbit review
dda15d24-65e1-4c27-a56d-75b90b118798covers622e429af2c86f077345b1a8fb3ded73ffeec1dewith no actionable findings. All nine Advisor specialists are clear for that same commit. Their complete findings, summaries, and E2E records were inspected; none adds an unresolved finding or additional E2E recommendation. The earlier thinking-default wording finding is resolved. The PR is ready for human review of the inactive staging scope; this is not approval to activate or merge.Recorded local-commit exception: for the earlier merge commit only, the user authorized proceeding past the inherited Pi receipt failure. The other 17 repository checks ran explicitly; only their aggregate pre-commit hook was skipped. Signing, remaining commit hooks, normal pre-push validation and hosted CI remained required. This is not a CI waiver or merge approval, and was not reused for the latest commit.
Activation requires a separate reviewed release change with immutable artifacts, runtime/template verification, target-hardware evidence, and the actual harness/request configuration recorded. A serving recipe does not qualify every harness. No private checkpoint identity, benchmark, or test artifact is published.
Signed-off-by: Prekshi Vyas prekshiv@nvidia.com