fix(inference): update Model Router pool - #11070
Conversation
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Model Router pool now uses updated NVIDIA Endpoint models. The routed inference E2E test uses shared runtime helpers and updated target metadata. Pi qualification records and assertion budgets were refreshed. ChangesModel Router refresh
Pi qualification refresh
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The documentation now describes routing through the configured NVIDIA Endpoints model pool. No merge-blocking behavior or user-impact risk remains. Sequence Diagram(s)sequenceDiagram
participant RoutedInferenceTest
participant RuntimeFixture
participant Sandbox
RoutedInferenceTest->>RuntimeFixture: request inference.local completion
RuntimeFixture->>Sandbox: execute routed completion probe
Sandbox-->>RuntimeFixture: return valid completion
RuntimeFixture-->>RoutedInferenceTest: record validCompletionReturned
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation The pull request replaces the retired model and adds a provider-routed completion check. It does not show a proactive model-retirement or availability gate, and the provided candidate evidence still reports HTTP 410 for the retired model. Acceptance criteria are therefore incomplete for [
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
Action performedReview triggered.
|
|
🌿 Preview your docs: https://nvidia-preview-pr-11070.docs.buildwithfern.com/nemoclaw |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 33fc9d3 in the TypeScript / code-coverage/cliThe overall line coverage in commit 33fc9d3 in the Show a line coverage summary of the most impacted files.
Updated |
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
PR Review Advisor run 33918962150 on exact head 9a224d9 is classified as an environmental review-provider failure, not candidate-owned. The Verification evidence specialist exhausted its checked-in five provider retries and received HTTP 429 with no response body or review text; the other eight specialists completed successfully. No code change is warranted, and this unavailable specialist result does not block the scoped PR. |
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
Signed-off-by: Rebecca Sliter <571084+rsliter@users.noreply.github.com>
|
PR Review Advisor finished for commit |
<!-- markdownlint-disable MD041 --> ## Outcome Adds the canonical dated documentation entry for v0.0.120 and records the release's material user-facing changes before tag planning. The Hermes rebuild guide now also documents the fail-closed immutable-base requirement for legacy sandboxes without an image hint. ## Reason Release planning requires a merged `docs/changelog/2026-09-04.mdx` containing exactly one `## v0.0.120` heading. The existing automation draft does not contain that required changelog and does not cover the full release scope, so this PR provides a fresh, independently reviewed release-docs update. ### Related issues Relates to #10919 ## Changes - Add three release-note lead paragraphs and detailed, user-facing v0.0.120 changes with canonical documentation routes. - Cover configuration export and doctor (#11015, #11012); Hermes runtime, recovery, and Discord policy (#10595, #11071, #11024, #10927, #10983, #10988, #10999, #11019, #10682); Shields retirement (#10722, #10996); OpenShell forwarding and runtime authority (#10695, #10814, #10815, #10810); onboarding and recovery (#10690, #10900, #11046, #10882, #10864); inference behavior (#10956, #10910, #11070); Deep Agents MCP projection safety (#10911, #10909); and provider-profile validation (#10884, #10895). - Scope the legacy Hermes immutable-base rebuild guidance to the Hermes-rendered recovery page. ## Verification - `npx vitest run --project integration test/generation/check-docs-links.test.ts test/generation/check-docs-published-routes.test.ts test/generation/post-merge-docs.test.ts` — 3 files and 125 tests passed. - `npm run docs` — passed with 0 errors and 5 existing Fern warnings. - Independent documentation audit — reconciled all 71 commits in `v0.0.119..origin/main`, validated all 29 PR links and published routes, and found no unsupported product claims or remaining corrections. - Normal `pre-commit`, `commit-msg`, and `pre-push` hooks — passed. - `git diff --check` — passed. - GitHub commit verification — `a22fe0989fd72c7daaa9b2e7a4734a3edc069aba` is Verified with reason `valid`. - Secret review — the diff contains no secrets, API keys, or credentials. ## Review notes The existing automation draft #10919 is intentionally left untouched. This PR supersedes its release-docs content with the complete canonical changelog and a variant-correct Hermes recovery update. --- Signed-off-by: Charan Jagwani <cjagwani@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Added release notes covering verified configuration export, host and gateway diagnostics, service forwarding, sandbox recovery, onboarding safeguards, inference retries, MCP projection safety, provider setup, and Discord runtime policy. - Clarified sandbox rebuild behavior, including use of the release-pinned immutable base image when required. - Documented that rebuilds stop before modifying sandbox data when the required image cannot be resolved or validated. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Outcome
The default Model Router pool now routes through GPT-OSS 20B instead of the retired Nemotron Nano endpoint. The existing provider-routed live target keeps one request that must return a valid completion while preserving redaction, actionable failure evidence, and sandbox cleanup.
Reason
The retired Nemotron Nano endpoint returns HTTP 410 and prevents the existing Model Router E2E from proving routed inference.
Related issues
Fixes #10969
Changes
nemotron-3-nano-reasoningandnvidia/nemotron-3-nano-30b-a3bwithgpt-oss-20b-highandopenai/gpt-oss-20bin the active pool and directly owned documentation.model-router-provider-routed-inferencetarget and keep mock parity explicit.Verification
9a224d978ac7fb765236114e5dff9f0f0854c059on base37cedc99007a776d4ea4591fcc74eb14bdcc0ef9.npm run validate:configs: all 52 config files passed.npm run test:e2e-phases:check: 132 tests across 88 files passed.npm run e2e:assertions:check: 1,885 direct assertions across 86 files passed.npm run validate:pr: passed on the exact candidate.model-router-provider-routed-inference. Revision-bound evidence records one passing target, a valid provider-routed completion, redacted credentials, and successful sandbox cleanup.npm run review:local: unavailable after the isolated local OpenShell gateway refused connections during specialist setup. The exact-head GitHub Advisor supplied the review evidence below.git diff --check: passed.Review notes
test/e2e/fixtures/phases/runtime.tsas a target-specific owner, but this is not valid:test/e2e/fixtures/is already a full-suite owning path intools/e2e/workflow-plan.mts, so changes there already select every catalogue target, including this one.Signed-off-by: Rebecca Sliter 571084+rsliter@users.noreply.github.com
Summary by CodeRabbit
New Features
Documentation