test(e2e): preserve Docker proof within assertion budget

[cv]

Outcome

Main-branch static checks accept the cloud onboarding Docker availability proof without increasing the live E2E assertion surface.

Reason

Run 33774909725 job 100714063864 failed because PR #10900 added one command assertion after the live E2E no-growth ratchet baseline was recorded.

Changes

• Fold the Docker-versus-Podman availability proof into the existing public installer command so its exit status remains part of the phase-1 artifact and existing install assertion.
• Remove the redundant command and matcher while preserving the same Docker-present and Podman-absent contract.

Verification

• Contributor validation: Signed commit hooks passed, including repository checks, E2E phase plans, source-shape budget, growth guardrails, secret scan, formatting, lint, and commitlint.
• Tests: npm run checks:repository passed with 1977 direct expect calls across 86 live E2E test files.
• Broad gate: npm run validate:pr passed against canonical origin/main 7bc678f after the final committed change.
• Secrets review: The diff contains no secrets, API keys, or credentials

Review notes

• Root-cause key: live-e2e-assertion-ratchet/cloud-onboard-docker-proof
• Source workflow: https://github.com/NVIDIA/NemoClaw/actions/runs/33774909725
• Failed job: static-checks (100714063864)
• Failure signature: cloud-onboard direct expect calls and assertion points grew by one beyond ci/e2e-assertion-budget.json.

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

• Tests
  • Updated cloud onboarding validation to check Docker availability during installation.
  • Added coverage ensuring Docker is required for the Docker runtime and absent for the Podman runtime.
  • Removed the separate post-install Docker CLI check.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 26e345f5-1c58-4705-9d27-09c76e676a0f

📥 Commits

Reviewing files that changed from the base of the PR and between 7bc678f and 4ce5f0b.

📒 Files selected for processing (1)

• test/e2e/live/cloud-onboard.test.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The cloud onboarding test now validates runtime-specific Docker availability during installation and removes the separate post-install Docker CLI check.

Changes

Cloud onboarding validation

Layer / File(s)	Summary
Runtime-specific installer validation test/e2e/live/cloud-onboard.test.ts	The installer requires discoverable Docker for the Docker runtime and unavailable Docker for Podman. The separate post-install Docker CLI assertion is removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4ce5f

The cloud onboarding E2E test now checks Docker availability during installation for the selected runtime and removes the redundant post-install probe. No merge-blocking risk remains.

Suggested reviewers: aasthajh

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: retaining Docker availability proof within the existing E2E assertion budget.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/e2e-assertion-budget-33774909725

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit 4ce5f0b in the fix/e2e-assertion-bu... branch remains at 96%, unchanged from commit 7bc678f in the main branch.

[github-actions]

PR Review Advisor finished for commit 4ce5f0b. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs