fix(ci): authenticate exact-base qualification evidence - #10842
Closed
prekshivyas wants to merge 16 commits into
Closed
fix(ci): authenticate exact-base qualification evidence#10842prekshivyas wants to merge 16 commits into
prekshivyas wants to merge 16 commits into
Conversation
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com> # Conflicts: # .github/workflows/managed-images.yaml # .github/workflows/managed-runtime-base-qualification.yaml # test/e2e/README.md # test/e2e/support/managed-runtime-comparison.test.ts # test/e2e/support/openshell-sdk-package-receipt.test.ts # test/inference/managed/managed-image-publication-workflow.test.ts # tools/e2e/managed-runtime-comparison.mts # tools/e2e/openshell-sdk-package-receipt.mts
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Contributor
|
PR Review Advisor finished for commit |
Collaborator
Author
|
Superseded by #10829; the fix and Advisor follow-up now live there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
PR qualification now consumes authenticated, exact-base evidence instead of relying on stale run metadata or unbound artifacts. OpenShell SDK selection and managed runtime activation both bind candidate, base, controller, run attempt, artifact digests, and cleanup evidence before they can affect the result.
Reason
Qualification of PR #10790 exposed two infrastructure gaps: the SDK consumer could reject a valid package because GitHub retained stale pull-request base metadata, and managed-image activation had no authenticated exact-base comparison for separating candidate regressions from base or infrastructure failures.
Related issues
Relates to #10790
Changes
Verification
npm run validate:prpassed after the final upstream refresh, including pre-commit, commit-msg, and pre-push checks.npm run validate:prpassed on commit2e280afd43fa500a12800cd332223b2a17adb063against upstreammaincommit16c21afdc858f5ca549b73d5e1fa6624bfc23c8b.Signed-off-by: Prekshi Vyas prekshiv@nvidia.com