fix(mcp): converge managed adapter credential revisions

[ericksoa]

Summary

Fix the post-#10173 MCP revision regressions in this PR. Managed adapters now register against a stable opaque credential revision observed through fresh OpenShell execs. A delayed provider projection can no longer leave committed adapter configuration stale, and teardown never derives credential authority from an unrelated provider resource version.

Related Issue

Fixes #10300
Related: #10298

Changes

• Require the same revision from two consecutive fresh OpenShell execs before treating a credential as ready.
• For credential-bearing add, prove the installed revision after policy activation, republish once, require a different stable revision, and register the adapter at that final revision.
• Re-register OpenClaw, Hermes, and Deep Agents Code adapters when fresh observation finds revision drift, then require three stable post-registration observations before success.
• Apply convergence to add, restart, runtime restore, and teardown rollback.
• Fail closed when teardown cannot prove a fresh opaque revision; never substitute provider resourceVersion.
• Require bounded revision-scoped placeholders in Deep Agents Code live evidence and the provider-rewrite probe.
• Cover concurrent add, delayed projection, crash recovery, restart, destroy, rebuild, stale or unstable authority, and raw-secret exclusion.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Sensitive paths changed (credentials and sandbox policy lifecycle)
• Exact-head sensitive-path advisor review is pending
• Non-success, skipped, or missing CI check accepted by maintainer: none accepted

Verification

Exact local head: 44088b59c

• 286/286 focused MCP, Hermes lifecycle, crash consistency, restart, teardown, destroy, and inherited watch-trigger tests passed
• npm run build:cli passed
• npm run checks:repository passed: 1,821 files, 5,760 edges, 0 cycles
• npx prek run --all-files passed
• No secrets, API keys, or raw credentials committed
• Exact-head CI and focused OpenClaw/Hermes/Deep Agents E2E are pending

---

Signed-off-by: Aaron Erickson aerickson@nvidia.com

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[github-actions]

🌿 Preview your docs: https://nvidia-preview-pr-10307.docs.buildwithfern.com/nemoclaw

[rsliter]

Reviewing exact commit 8068bd5. Two merge blockers remain. First, the effective MCP diff still includes unrelated PR Review Advisor workflow, tool, test, and documentation rewrites that are not described by this PR and must be removed from the candidate. Second, this branch carries material Charan Jagwani work from #10270, while #10270 does not contain Charan own PR-body Signed-off-by declaration. The superseded-PR attribution policy forbids selecting or merging the transferred replacement until Charan adds that declaration personally. Current CI and changes-requested gates remain separate blockers.

[cjagwani]

Fresh CI on 8068bd5f has Hermes managed startup green. CLI shard 10 is failing for an unrelated watch-trigger baseline mismatch: test/helpers/vitest-watch-triggers.ts and test/repository/vitest-watch-triggers.test.ts both replace the removed OpenShell advisor test with pr-review-advisor-workflow-boundary.test.ts a second time. runTests() dedupes the actual list to one entry, while the expectation still contains two. Dedupe that path in both lists and rerun shard 10.

[cjagwani]

Attribution blocker cleared: I added my personal Signed-off-by: Charan Jagwani <cjagwani@nvidia.com> declaration to the #10270 PR body.

For the remaining scope blocker, please reset the unrelated PR Review Advisor changes in #10307 to current main, not just the duplicate expectation. The effective diff still includes .github/workflows/pr-review-advisor.yaml, tools/pr-review-advisor/**, test/automation/pull-requests/pr-review-advisor-*, and the related vitest-watch-triggers edits. After that, rerun CI; shard 10 should clear with the unrelated baseline removed.

[cv]

LGTM on green

[github-actions]

PR review advisory complete for commit 44088b5: read the full review. Read it before deciding whether to request changes, approve, or merge this PR.

All previous runs

Resolved in subsequent commits. Rebecca confirmed the teardown blocker was fixed at b5f39e5; the unrelated diff and attribution blockers are cleared at 44088b5, which has independent exact-head approval from Carlos.