Skip to content

Fix parallel external source test swapped parameters#6425

Merged
mzient merged 1 commit into
NVIDIA:mainfrom
mzient:fix_parallel_external_source_test
Jul 15, 2026
Merged

Fix parallel external source test swapped parameters#6425
mzient merged 1 commit into
NVIDIA:mainfrom
mzient:fix_parallel_external_source_test

Conversation

@mzient

@mzient mzient commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

This PR fixes the swapped num_workers/batch_size, which resulted in running out of handles.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@mzient
mzient force-pushed the fix_parallel_external_source_test branch from 21355fc to 6ee258d Compare July 14, 2026 14:49
@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes parameter binding in two parallel external source tests. The main changes are:

  • Reorders test_exception_propagation Cartesian parameters so num_workers is bound first.
  • Reorders test_layout Cartesian parameters in the same way.
  • Keeps the generated parameter combinations the same while correcting which values reach batch_size and py_num_workers.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
dali/test/python/test_external_source_parallel.py Reorders two parameterized test signatures and decorators so worker counts and batch sizes bind to the intended arguments.

Reviews (1): Last reviewed commit: "Fix num_workers swapped with batch_size ..." | Re-trigger Greptile

@dali-automaton

Copy link
Copy Markdown
Collaborator

CI MESSAGE: [57977233]: BUILD STARTED

@JanuszL JanuszL self-assigned this Jul 14, 2026
@dali-automaton

Copy link
Copy Markdown
Collaborator

CI MESSAGE: [57977233]: BUILD PASSED

@mzient
mzient merged commit 6387779 into NVIDIA:main Jul 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants