Fix parallel external source test swapped parameters#6425
Merged
Conversation
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
mzient
force-pushed
the
fix_parallel_external_source_test
branch
from
July 14, 2026 14:49
21355fc to
6ee258d
Compare
Contributor
|
| Filename | Overview |
|---|---|
| dali/test/python/test_external_source_parallel.py | Reorders two parameterized test signatures and decorators so worker counts and batch sizes bind to the intended arguments. |
Reviews (1): Last reviewed commit: "Fix num_workers swapped with batch_size ..." | Re-trigger Greptile
Collaborator
|
CI MESSAGE: [57977233]: BUILD STARTED |
JanuszL
approved these changes
Jul 14, 2026
Collaborator
|
CI MESSAGE: [57977233]: BUILD PASSED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
This PR fixes the swapped num_workers/batch_size, which resulted in running out of handles.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A