fix(train): argparse type=bool prevents disabling boolean (+1 more)

[andrewwhitecdw]

This PR addresses 2 issues in train.py.

Fix 1

fix: argparse type=bool prevents disabling boolean flags

Fix: Replace:

    parser.add_argument("--fine_tuning", default=False, type=bool)

    parser.add_argument(
        "--debug",
        default=False,
        type=bool,
        help="debug mode. skips validation loop throughout training",
    )
    parser.add_argument(
        "--evaluate",
        default=False,
        type=bool,
        help="only run evaluation from checkpoint and exit",
    )

with:

    parser.add_argument("--fine_tuning", action="store_true")

    parser.add_argument(
        "--debug",
        action="store_true",
        help="debug mode. skips validation loop throughout training",
    )
    parser.add_argument(
        "--evaluate",
        action="store_true",
        help="only run evaluation from checkpoint and exit",
    )

Fix 2

fix: remaining argparse flags use broken type=bool

Fix: Replace:

    parser.add_argument(
        "--skip_seen",
        default=False,
        type=bool,
        help="skip seen dataset. useful for test set inference",
    )
    parser.add_argument(
        "--save_audio",
        default=False,
        type=bool,
        help="save audio of test set inference to disk",
    )

with:

    parser.add_argument(
        "--skip_seen",
        action="store_true",
        help="skip seen dataset. useful for test set inference",
    )
    parser.add_argument(
        "--save_audio",
        action="store_true",
        help="save audio of test set inference to disk",
    )

Files changed

• train.py