Repository navigation
fix(translation): preserve responses tool-use stop reasons - #1317
grahamking merged 1 commit into
Conversation
Signed-off-by: David Gardner <dagardner@nvidia.com>
|
@coderabbitai fullreview |
|
Action performed
|
|
No actionable comments were generated in the recent review. WalkthroughThe response decoder now preserves ChangesResponse Translation
Estimated code review effort: 2 (Simple) | ~8 minutes Merge Risk:
|
What
Preserve
ToolUsewhen decoding buffered Responses output that contains a tool call followed by assistant text. Extend the existing mixed text/tool test to check the decoded stop reason in both item orders.Why
Trailing text overwrote the tool-use stop reason with
EndTurn. Chat and Anthropic translations then reported ordinary completion while still containing a tool call.Notes for reviewers
The decoder change keeps the existing response-level token-limit override.
Validation passed:
cargo test --offline -p switchyard-translationcargo clippy --offline --workspace --all-targets --locked -- -D warningscargo fmt --all --checktool_use, one retained tool call, exit code 0.Summary by CodeRabbit