Hide reasoning traces from IORails output#2088
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This closes a safety gap in non-streaming
IORailswhere reasoning traces could be reattached to the returned assistant message after output rails had already run.Root cause
IORails.generate_async()extracted reasoning, ran output rails on the stripped answer text, and then prepended the reasoning back into the returnedcontentas<think>...</think>. That allowed reasoning traces to bypass output rails and still be returned to the caller.What changed
IORailsresponse content<think>...</think>blocks from returned content before output rails runWhy this approach
This is the smallest safety fix with the lowest review surface. It also aligns non-streaming
IORailswith the existing streaming behavior, which already drops reasoning from caller-visible output.Validation
./.venv/bin/python -m pytest tests/guardrails/test_iorails.py tests/guardrails/test_iorails_streaming.py