Add num_workers_per_node() as a method for stages + Per-node worker sizing for download stages#2198
Draft
praateekmahajan wants to merge 5 commits into
Draft
Conversation
Signed-off-by: Praateek <praateekm@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 82603dd |
Fold _compute_kwargs and _build_resource_kwargs into a single _managed_map_batches_kwargs that builds the full Curator-managed set (compute strategy + CPU/GPU reservations + max_calls) in one place. Signed-off-by: Praateek <praateekm@gmail.com>
Contributor
Author
|
/ok to test 59e866e |
The value is num_workers_per_node * node_count, i.e. the total cluster-wide Ray Data pool size (ActorPoolStrategy/TaskPoolStrategy size is a total replica count), not a per-node count. SPREAD scheduling then distributes it so each node gets ~num_workers_per_node replicas. Rename for clarity and document the scaling. Signed-off-by: Praateek <praateekm@gmail.com>
Contributor
Author
|
/ok to test fc50118 |
…ax_workers_per_node Signed-off-by: Praateek <praateekm@gmail.com>
Contributor
Author
|
/ok to test a90f090 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessingStage.num_workers_per_node()(method-only) andwith_(num_workers_per_node=...).num_workers/num_workers_per_node/ actor-poolmin/max/initial_workers) once at stage construction, and drop the duplicated checks from the Ray Data, Ray Actor Pool, and Xenna backends.Behavior/API changes
xenna_stage_spec()["num_workers_per_node"]path and theImageDuplicatesRemovalStage(num_workers_per_node=...)constructor arg; use.with_(num_workers_per_node=...)instead (migratedImageDuplicatesRemovalStageand the CallHome tutorial).Fixes #2197