Skip to content

🎨 Palette: Add missing accessibility label to Reset to Base button - #178

Open
NSEvent wants to merge 1 commit into
mainfrom
palette/accessibility-label-settings-11771377997476547654
Open

NSEvent wants to merge 1 commit into
mainfrom
palette/accessibility-label-settings-11771377997476547654

Conversation

@NSEvent

@NSEvent NSEvent commented Sep 17, 2026

Copy link
Copy Markdown
Owner

💡 What

Added a missing .accessibilityLabel to the icon-only "Reset to base" button in SettingsViews.swift (specifically within JoystickSettingsView).

🎯 Why

Icon-only buttons with just a .help() modifier provide tooltips for mouse users but lack explicit accessibility labels for screen readers (VoiceOver). Ensuring symmetry by adding .accessibilityLabel provides a complete and inclusive experience.

♿ Accessibility

VoiceOver users navigating the Joystick Settings will now hear "Reset to base (inherit)" instead of a generic or missing label when encountering the arrow.uturn.backward button.


PR created automatically by Jules for task 11771377997476547654 started by @NSEvent

Summary by CodeRabbit

  • Accessibility
    • Added an accessibility label to the per-layer override reset button, clarifying that it resets the setting to the base inherited value.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4196b9c3-554e-4cb9-b571-8946a25cb9bd

📥 Commits

Reviewing files that changed from the base of the PR and between fa94e2d and 93c964c.

📒 Files selected for processing (1)
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/SettingsViews.swift

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The per-layer stick override reset button now has an accessibility label that matches its existing help text.

Changes

Accessibility Update

Layer / File(s) Summary
Label the override reset button
XboxControllerMapper/XboxControllerMapper/Views/MainWindow/SettingsViews.swift
The reset button in layerOverrideSlider now uses .accessibilityLabel("Reset to base (inherit)").

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 93c96

The reset button now has a clear VoiceOver label, with no remaining merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a missing accessibility label to the “Reset to Base” button.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/accessibility-label-settings-11771377997476547654

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant