Skip to content

🎨 Palette: Add dynamic tooltip and accessibility label to keyboard toggle button - #176

Open
NSEvent wants to merge 3 commits into
mainfrom
palette/touchpad-region-mapping-a11y-2807393692825488993
Open

NSEvent wants to merge 3 commits into
mainfrom
palette/touchpad-region-mapping-a11y-2807393692825488993

Conversation

@NSEvent

@NSEvent NSEvent commented Sep 15, 2026

Copy link
Copy Markdown
Owner

💡 What: Added .help and .accessibilityLabel modifiers to the keyboard toggle button in TouchpadRegionMappingSheet.swift that dynamically update based on the button's state ("Show Keyboard" vs "Hide Keyboard").
🎯 Why: Icon-only buttons whose icons change dynamically are confusing for screen reader users and those who rely on hover tooltips if their descriptions don't match the current state. This makes the action clear and unambiguous.
Accessibility: Added accessibilityLabel that accurately reflects the current action (show/hide), making it usable for VoiceOver users.


PR created automatically by Jules for task 2807393692825488993 started by @NSEvent

Summary by CodeRabbit

  • Accessibility

    • Added localized help text and accessibility labels to the touchpad mapping sheet’s keyboard toggle.
    • Labels update dynamically to indicate whether the keyboard can be shown or hidden.
  • Documentation

    • Added guidance for providing accessibility labels and help text on dynamic icon buttons.
  • Diagnostics

    • Reduced debug-only logging during controller detection, database loading, input handling, and profile switching.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 681b23f1-c87b-41cb-9fef-6c0fe0043b3b

📥 Commits

Reviewing files that changed from the base of the PR and between a261e81 and 6815fd0.

📒 Files selected for processing (1)
  • XboxControllerMapper/XboxControllerMapper/Services/Mapping/MappingEngine.swift

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 831ee4a6-97a4-4e6f-ab2c-c551437427f8

📥 Commits

Reviewing files that changed from the base of the PR and between 13ec85e and a261e81.

📒 Files selected for processing (4)
  • XboxControllerMapper/XboxControllerMapper/Services/Controller/ControllerService+LED.swift
  • XboxControllerMapper/XboxControllerMapper/Services/Controller/GameControllerDatabase.swift
  • XboxControllerMapper/XboxControllerMapper/Services/Mapping/MappingEngine.swift
  • XboxControllerMapper/XboxControllerMapper/Services/Profile/ProfileManager.swift

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The keyboard toggle now provides state-dependent help and accessibility labels. A learning entry documents this pattern. Selected debug-only logs are disabled in controller, database, mapping, and profile services.

Changes

UI accessibility and debug output

Layer / File(s) Summary
Keyboard toggle accessibility labels
XboxControllerMapper/XboxControllerMapper/Views/MainWindow/TouchpadRegionMappingSheet.swift, .Jules/palette.md
The keyboard toggle now provides localized help and accessibility text for the “Show Keyboard” and “Hide Keyboard” states. The learning entry documents the same requirement for dynamic icon buttons.
Debug log suppression
XboxControllerMapper/XboxControllerMapper/Services/Controller/*, XboxControllerMapper/XboxControllerMapper/Services/Mapping/MappingEngine.swift, XboxControllerMapper/XboxControllerMapper/Services/Profile/ProfileManager.swift
Selected debug-only logs are commented out. Existing return paths and profile activation remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to a261e

The PR improves keyboard-toggle clarity and reduces selected debug output without changing runtime control flow, so it is ready to merge with normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding dynamic tooltip and accessibility label text to the keyboard toggle button.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/touchpad-region-mapping-a11y-2807393692825488993

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

google-labs-jules Bot and others added 2 commits September 15, 2026 09:04
Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant