🎨 Palette: [Accessibility] Improve VoiceOver and Keyboard Navigation for Chord and Sequence Lists

[NSEvent]

💡 What: Replaced .onTapGesture with a proper Button wrapper for ChordRow and SequenceRow.
🎯 Why: .onTapGesture prevents interactive elements from properly supporting keyboard focus and VoiceOver accessibility. Using a Button with .buttonStyle(.plain) fixes this while maintaining visual appearance.
📸 Before/After: Not applicable (no visual change).
♿ Accessibility: Improved keyboard navigation and screen reader support for chord and sequence list rows.

---

PR created automatically by Jules for task 13463346906967767145 started by @NSEvent

Summary by CodeRabbit

• Accessibility
  • Improved keyboard navigation and VoiceOver support for chord and sequence list rows.
  • Made entire row content areas activate editing through standard buttons while preserving their tappable areas.
• Documentation
  • Added guidance for using accessible buttons instead of tap gestures on structural views.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 56c16196-f97c-421d-8f6d-dca1f712a212

📥 Commits

Reviewing files that changed from the base of the PR and between f1ceae4 and 952f12a.

📒 Files selected for processing (2)

• .Jules/palette.md
• XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ChordSequenceListViews.swift

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

Chord and sequence list rows replace structural-view tap gestures with plain SwiftUI buttons that invoke onEdit. The rows retain rectangular content shapes. The palette records the accessibility pattern.

Changes

Accessible row actions

Layer / File(s)	Summary
Button-based edit actions XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ChordSequenceListViews.swift, .Jules/palette.md	Chord and sequence row content now uses plain buttons for onEdit while preserving rectangular content shapes. The palette documents the corresponding accessibility pattern.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 952f1

This change replaces tap gestures with standard buttons so chord and sequence rows support keyboard focus and VoiceOver while preserving their existing edit behavior. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the accessibility change and the affected chord and sequence lists. It accurately reflects the replacement of tap gestures with buttons to improve VoiceOver and keyboard n…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title clearly identifies the accessibility change and the affected chord and sequence lists. It accurately reflects the replacement of tap gestures with buttons to improve VoiceOver and keyboard navigation.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch palette-ux-accessibility-chords-13463346906967767145

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}