Apply HUD clock time format for any mod language, not just Thai#1
Open
ThatHunky wants to merge 1 commit into
Open
Apply HUD clock time format for any mod language, not just Thai#1ThatHunky wants to merge 1 commit into
ThatHunky wants to merge 1 commit into
Conversation
The DayTimeMoneyBox draw patch that renders the HUD clock using the mod language's time format was gated behind a hardcoded check for ELL.StardewValleyTHAI. Any other custom language (e.g. the Ukrainian translation Pereclaw.ukrainizacija) fell through to the vanilla mobile switch, which has no LanguageCode.mod case and renders a 12-hour clock with no AM/PM marker. Changes: - ModEntry: enable the patch whenever the loaded mod language defines a ClockTimeFormat or TimeFormat, instead of matching the Thai pack ID - DayTimeMoneyBoxThaiFormat: prefer ClockTimeFormat for the HUD clock (matching desktop DayTimeMoneyBox behavior), fall back to TimeFormat
Owner
|
Nice!, i will check it within 1-2 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DayTimeMoneyBox draw patch that renders the HUD clock using the
mod language's time format was gated behind a hardcoded check for
ELL.StardewValleyTHAI. Any other custom language (e.g. the Ukrainian
translation Pereclaw.ukrainizacija) fell through to the vanilla mobile
switch, which has no LanguageCode.mod case and renders a 12-hour clock
with no AM/PM marker.
Changes:
a ClockTimeFormat or TimeFormat, instead of matching the Thai pack ID
(matching desktop DayTimeMoneyBox behavior), fall back to TimeFormat