Add "Wants" dependency to systemd service - #508
Open
cvengler wants to merge 1 commit into
Open
Conversation
Having an actual "Wants" dependency is generally considered good hygiene in systemd services, as a dependency with "After" only ensures that the service gets started after "network-online.target", but it does not necessarily ensure that "network-online.target" is started at all. Practically speaking, it should not matter a lot, because there will most likely be another dependency on the systemd that makes use of "network-online.target", but defining it explicitly is still good practice in my opinion, as well as the opinion of various downstream distributions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having an actual "Wants" dependency is generally considered good hygiene in systemd services, as a dependency with "After" only ensures that the service gets started after "network-online.target", but it does not necessarily ensure that "network-online.target" is started at all.
Practically speaking, it should not matter a lot, because there will most likely be another dependency on the systemd that makes use of "network-online.target", but defining it explicitly is still good practice in my opinion, as well as the opinion of various downstream distributions.