Introduce an access control service layer. - #971
Merged
Conversation
Philip-NLnetLabs
marked this pull request as draft
August 24, 2026 15:09
Philip-NLnetLabs
marked this pull request as ready for review
August 26, 2026 15:24
bal-e
approved these changes
Sep 3, 2026
bal-e
left a comment
bal-e
left a comment
Contributor
There was a problem hiding this comment.
It's a lot of code, but it looks good to me :)
Comment on lines
+656
to
+657
| let zones = &self.center.state.lock().unwrap().zones; | ||
| let Some(zone) = zones.get(&qname).map(|z| &z.0) else { |
Contributor
There was a problem hiding this comment.
This will hold on to a lock of the global state for the duration of this function (but not the full duration of the XFR). To make sure this doesn't silently introduce hangs in the future, could you put the code locking center.state, looking up the zone, and copying out Arc<Zone> in a {} block?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #763
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?