zone edit command to change zone source and policy - #906
Open
tertsdiepraam wants to merge 2 commits into
Open
Conversation
bal-e
reviewed
Jul 16, 2026
|
|
||
| if let Some(policy) = policy { | ||
| let mut handle = zone.write_handle(center); | ||
| let old = handle.state.policy.replace(policy.latest.clone()); |
Contributor
There was a problem hiding this comment.
I think you also need to un-link the zone from the policy here...
Contributor
Author
There was a problem hiding this comment.
I think I got it now, please take a look.
Contributor
|
I'll continue this work. |
Contributor
|
Note: the CLI command should wait until all policy changes (including keyset stuff; note there are some |
ximon18
added
the
cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for the following controls:
It's also possible to pass both.
The output could be improved if for example the new policy is the same policy that is already in use.
Closes #903
Closes #868
Closes #846