Repository navigation
Fix deferred minors from #55–#57; add small-team setup guide - #58
Merged
Merged
Conversation
… precedence; document GitLab variables
…uctions; complete the MCP docs
…fields, strengthen the draft reload; clarify fixture guidance
… credentials; guide uses env references and defines every profile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the minor findings deferred from #55, #56 and #57, and adds a setup guide for a small team.
Fixes
status: leftexpects nothing inprofile check, even when a directory group still assigns them profiles.access review: refuses existingNNN.json/NNN.execution.jsonbefore discovery; escapes Markdown in--detailsummaries; the old-index.jsonrefusal names the folder and the CI remedy.permesh-plan.ymlpush run on the default branch of this repository, including runs that exited 4 or 6, which still hold the matched plans. The job exits like the CLI for the worst plan (errors, then 3, 4, 6). Behavioural tests run the workflow's shell steps with stand-inghandpermesh.PERMESH_GOOGLE_CLIENT_SECRETandPERMESH_GOOGLE_REFRESH_TOKEN, because a Google access token expires within an hour, too short for weekly CI. The README usesenv://references instead of the keychain-onlyauth login. GitLab docs say not to mark provider variables Protected.permesh mcp:profiles/removelists get a specific message, and the schemas setminItems: 1;report.complete;access-plan-move.jsonandcheck-report-notifications.json(with notifications enabled; failure reasons normalized as human text). There's a renamed-field self-check on the plan fixture and a stronger reload check for theprofile suggestdraft. README and ADR 0036 now state coverage accurately.Docs
docs/team-setup.md: about 10 people on GitHub and Google Workspace, from repository to weekly CI and reviewed joins, moves and leaves. Linked fromdocs/README.mdand getting started.Validation
cargo fmt --check,cargo clippy --workspace --all-targets -D warningsand docs check are clean.cargo test --workspace: 734 passed, 0 failed.Rulings
groupscapability: completeness unchanged. Such a provider can't report group routes, and requiring memberships would make every leave there permanently incomplete. Documented in access-plans.md.Deferred minors
access verifynow applieslefttoo: verifying an old join/move plan for someone since marked left lists all their access asextra(exit unchanged)..pathexactly; if GitHub ever adds@ref, every run is refused.--detailtext; a leading-in an operation can nest a list.check_outsilently passes when--outcan't be listed; on Windows000.JSONisn't matched.profile suggeststraight intoprofiles/; a failed run leaves an empty file that breaks profile loading.ci/providers.txtcome from.