Skip to content

Develop 47462 trxn_id repeat bug #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apple843119 merged 3 commits into from
Sep 1, 2026
Merged

Develop 47462 trxn_id repeat bug #160

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab37350
Refs #47462,feat:trxn_id repeat bug
Chen-LiYin Aug 13, 2026
48c39e3
Refs #47462, feat: change to english
Chen-LiYin Aug 31, 2026
3a641e2
Refs #47462,feat: remove comment
Chen-LiYin Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions CRM/Event/Form/Participant.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,6 +1022,34 @@ public static function formRule($values, $files, $self) {
$errorMsg['contribution_status_id'] = ts("Please select a valid payment status before updating.");
}

if (CRM_Utils_Array::value('record_contribution', $values) &&
!empty($values['trxn_id'])
) {
$trxnId = $values['trxn_id'];
$excludeContributionId = NULL;

// exclude that participant's own contribution from the duplicate check.
if ($self->_id && $self->_paymentId) {
$excludeContributionId = CRM_Core_DAO::getFieldValue(
'CRM_Event_DAO_ParticipantPayment',
$self->_id,
'contribution_id',
'participant_id'
);
}

$dupQuery = "SELECT id FROM civicrm_contribution WHERE trxn_id = %1";
$dupParams = [1 => [$trxnId, 'String']];
if ($excludeContributionId) {
$dupQuery .= " AND id != %2";
$dupParams[2] = [$excludeContributionId, 'Integer'];
}
$dupDao = CRM_Core_DAO::executeQuery($dupQuery, $dupParams);
if ($dupDao->fetch()) {
$errorMsg['trxn_id'] = ts('Transaction ID already exists in Database.');
}
}

// do the amount validations.
//skip for update mode since amount is freeze, CRM-6052
if ((
Expand Down