chore(deps): keep piet and piet-coregraphics in one pull request - #41
Merged
Conversation
piet-coregraphics pins an exact piet, so a piet major arriving on its own cannot compile: `CoreGraphicsContext` stops implementing `RenderContext` and the macOS build fails with a dozen E0599s naming `fill`, `stroke`, `draw_text` and `finish` - none of which says that the cause is a version split. That is the one shape majors should be grouped in, against this file's general rule, because the pair is a single decision rather than two. The Cargo.toml note said core-graphics 0.24 was needed "if we use piet 0.7". It is needed for 0.8 as well, and cocoa 0.24 does not take it, so the note now says what the next bump actually costs: a coordinated macOS stack upgrade. Claude-Session: https://claude.ai/code/session_01Dhii8pMkUcUEWKjhDwxzAX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37 bumps
piet0.6.2 → 0.8.0 on its own and cannot merge. The macOS build fails with a dozenE0599s:Every one of those is a
RenderContextmethod. They did not disappear from the API —piet-coregraphicsstayed on 0.6.2 and pins an exactpiet, so the graph carries piet 0.6.2 and piet 0.8.0 at once andCoreGraphicsContextimplements the trait from the copy nothing else is using. The error names the symptom and never the cause.This file argues, with reasons, that majors should not be grouped. This pair is the exception it does not cover: it is one decision, not two, and neither half compiles alone.
The
Cargo.tomlnote also understated the cost. It said core-graphics 0.24 would be needed "if we use piet 0.7";piet-coregraphics0.8.0 requirescore-graphics ^0.24too, and this tree pinscore-graphics = "0.22"undercocoa = "0.24". So the next piet bump is a coordinated macOS stack upgrade, not a dependency bump. The note now says that.Closing #37 as unmergeable in its current shape; the group makes the next attempt arrive whole.
https://claude.ai/code/session_01Dhii8pMkUcUEWKjhDwxzAX