fix(bootstrap): bind device setup and source review to their owning roots - #140
Merged
Conversation
…oots Signed-off-by: rldyourmnd <danil@nddev.it.com>
…acts Signed-off-by: rldyourmnd <danil@nddev.it.com>
Signed-off-by: rldyourmnd <danil@nddev.it.com>
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Device bootstrap assumed that the engine source root also contained the private estate and sibling OS installer. Source review had the inverse ownership error: a public module was required to be the private control plane, while provider-only discovery reported every repository as needing onboarding without reading any anchor.
Add an explicit consuming estate root and require both declared module checkouts to match their gitlinks before using them. Keep source builds/version identity in the engine root and registration/device intent in the estate root. Let a public module review its own register through the existing local policy boundary. Report unobserved identities honestly, preserve historical audit bytes, fix the first-key YAML reader case, and remove a tracked device-local marker. Refresh seed/bootstrap/source documentation and generated projections from canonical inputs.
Validation: full Go quick gate and all 48 Python tests pass. Real-Git bootstrap fixtures cover separate roots, paths with spaces, dirty/unpinned installers and read-only behavior. Existing historical audit roundtrip tests pass. A real source-review plan succeeds in the public module with its own repository scope. Shell validation and the final focused bootstrap suite pass; generated projections are current.