feat(estate): classify a repository by its account, not by being a fork - #131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner decided on 2026-09-10 that GDS carries no fork concept. Whether GitHub calls a repository a fork describes how it was created, not who is responsible for it — so it stops being a classification, and a repository belongs to the account that holds it.
core/estate/compiler.go— owner classification is the single fallback, and selector matching no longer readsmatch.fork.core/validation/estate.go—GDS_ESTATE_SELECTOR_PORTFOLIO_MISMATCHwas keyed onmatch.forkbeing present. Dropping that field would have silently retired the check, so the rule is re-keyed on what it always meant: a selector that does not narrow by name, visibility or lifecycle is the owner's general one and must assign the owner's declared portfolio.schemas/v1/owner.schema.json—fork_portfoliois no longer required. It stays accepted so existing configurations remain valid; nothing reads it any more.policies/portfolios/fork-default.yamland the fork selectors, ownerfork_portfolioentries,fork:match clauses andforksworkspace roots leave the fixture estate.core/assurance— the bounded-evidence invariant was "N repositories landed in a fork portfolio", a count that would now be zero forever and prove nothing. It asserts instead that every fork is classified like any other repository of its account: matched by a selector, carrying a portfolio.One consequence worth naming. Organization forks become
managed, because a managed account now manages everything it holds and a fork is no longer a way to sit outside that.NDDev-it-comandNDDev-OpenNetworkhold zero forks today, so nothing changes in practice — the compiler test asserts it deliberately.Sequencing: the private estate must not carry fork selectors when this lands, or its general and fork selectors collide at equal priority. NDDev-it-com/github-device-sync-estate#557 removes them and validates cleanly under both the current release and this change, so it can land first and independently. Verified with both in place:
scripts/validate_go_core.sh --quickexits 0, 66 packages ok.https://claude.ai/code/session_01CKXKXND4zAgWisTtatyTHX