fix(feedback): preserve late failures and bounded per-job delivery - #453
Merged
Conversation
Signed-off-by: rldyourmnd <danil@nddev.it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early delivery previously used one marker for an entire workflow attempt. Once the first failed job was reported, later failures were silently treated as already delivered.
In early mode, publish and deduplicate each exact repository/run/attempt/job subject. Preserve prior issues and human edits, including closed issues. Adopt legacy snapshots only for the jobs actually listed with the exact source identity. Return all subject receipts, reconcile ambiguous writes, and allow a durable executor to defer exhausted subjects while other jobs continue. Completed-only callers retain their existing interface and attempt-level behavior. No additional API mutation type or token scope is introduced.
Validation: reproduced the missing later failure before the fix; all 35 publisher tests pass. The private consumer's 31 integration tests pass for independent durable write budgets, restarts, exhaustion without starvation, and preservation of all early references in final receipts.
Completes the publisher portion of #426; consumer activation is tracked in its owning private repository.