fix(deps): watch the nested starlarkexec module so root bumps stop breaking it - #448
Merged
Merged
Conversation
…eaking it internal/incusplacement/starlarkexec requires the root module, so the root's dependency graph moving is enough to leave its go.mod stale. The harness test shells `go test` and `go vet` into that directory, and Go answers "updates to go.mod needed". That is what happened to #446: a root-only bump of golang.org/x/sys turned three CI jobs red without touching a line of that module's own code. dependabot.yml listed gomod at / only, so the nested module was never watched -- the same shape as the npm manifest in #439. Claude-Session: https://claude.ai/code/session_01CKXKXND4zAgWisTtatyTHX
rldyourmnd
added a commit
that referenced
this pull request
Sep 10, 2026
The group bump moved golang.org/x/sys to 0.48.0 in the root module. internal/incusplacement/starlarkexec requires the root module, so its own go.mod still asked for 0.47.0, and starlarkexec_hook_test.go — which shells `go test` and `go vet` into that directory — got "updates to go.mod needed" and failed Race, Static and build, and Test. Tidied with GOTOOLCHAIN=go1.26.7, the version both go.mod files declare; this workstation manages only 1.26.5, so a plain `go mod tidy` here is refused. TestStarlarkExecutionHarness passes against the tidied module. #448 adds this directory to dependabot so the two stay in step from now on. Claude-Session: https://claude.ai/code/session_01CKXKXND4zAgWisTtatyTHX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/incusplacement/starlarkexecis a nested module that requires the root module, so the root's dependency graph moving is enough to leave itsgo.modstale.starlarkexec_hook_test.goshellsgo testandgo vetinto that directory, and Go answersupdates to go.mod needed; to update it: go mod tidy.That is exactly what happened to #446. Dependabot bumped
golang.org/x/sys0.47.0 → 0.48.0 in the root; the nested module still requires 0.47.0;Race,Static and buildandTestall went red without a line of that module's own code changing..github/dependabot.ymllistedgomodat/only, so the nested module was never watched — the same shape as the npm manifest in #439, found because that one made me look for others. This adds the directory so the two move in step.This does not fix #446 by itself. That branch still needs
go mod tidyinside the nested module. I could not run it here and did not guess at the result: both modules declarego 1.26.7, and this workstation has only Go 1.26.5 managed under~/.local/share/rldyour/go/, withGOTOOLCHAIN=localin force. CI resolvesgo-version-file: go.mod, so it has 1.26.7 and can tidy correctly.Worth a separate look: the bootstrap contract holds
goat 1.26.6, this device carries 1.26.5, and these modules require 1.26.7 — three different numbers for one toolchain.https://claude.ai/code/session_01CKXKXND4zAgWisTtatyTHX