fix: retain security evidence when artifact delivery fails - #100
Merged
Conversation
Signed-off-by: rldyourmnd <danil@nddev.it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Private consolidated security jobs fail after successful scans when GitHub artifact storage refuses the final report upload. Both variants now require a complete checksummed run-log ZIP when artifact upload fails. The archive preserves all four redacted reports and exact run identity; missing, symlinked, non-regular, changing, malformed or oversized inputs fail closed. Scanner failures remain blocking regardless of delivery outcome.
Refresh two expired GitLab allowance records from their current primary sources, with separate review deadlines.
Type of change
Threat-model note
No additional destination or authentication authority. The fallback uses the existing private run log and visibility. It opens only four fixed report names with no-follow/nonblocking descriptors, bounds every input to 4 MiB, validates SARIF and capture stability, and emits base64 only after a complete deterministic ZIP exists. SHA-256, byte count, member checksums, repository, source commit, run and attempt permit exact recovery. Failure of both transports and scanner failures remain failures. Native SARIF publication in the paid variant is unchanged.
Permissions diff
No permission changes. Private-free remains
contents: read; the paid variant retains its existingactions: read,contents: readandsecurity-events: writescopes.Validation
validate_all.pythrough the isolated launcher: all tiers pass.used_bysets are unchanged.Hosted fallback execution is a consumer rollout check, not claimed by these local tests.