Fix website generation for non-default plot types - #463
Merged
Conversation
Any plotting script using a plot_type outside "default_ptypes" crashed website generation with "TypeError: unhashable type: 'collections.OrderedDict'" from template_index.html. The loop meant to register an unrecognized plot type appended the plot_types dict rather than the plot type itself, so index.html then tried to use that dict as a dictionary key. Also copy the default list before appending. "res" is the shared variable-defaults dictionary and this loop runs once per web-data entry, so appending in place permanently modified the loaded defaults. Verified with a plotting script registering plot_type "CloudRegimes": the tab now renders on index.html and the generated site has no broken internal links. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
nusbaume
self-requested a review
August 13, 2026 20:15
nusbaume
approved these changes
Aug 13, 2026
brianpm
pushed a commit
to brianpm/ADF
that referenced
this pull request
Aug 21, 2026
The merge from main brings in PR NCAR#463, which fixes adf_web.py to append the plot type rather than the whole plot_types dict to avail_plot_types. That was the blocker recorded in the WEB_PLOT_TYPE comment: before it, any plot type outside default_ptypes made the index template fail on an unhashable dict, so this diagnostic had to borrow the generic "Special" tab. The figures now land under a "CloudRegimes" tab. Verified with create_html: true -- mean_diag_CloudRegimes.html is generated, index.html links to it, and all 7 plot pages match their figure names with no broken hrefs or missing images anywhere in the site. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any plotting script using a plot_type outside "default_ptypes" crashed website generation with "TypeError: unhashable type: 'collections.OrderedDict'" from template_index.html.
The loop meant to register an unrecognized plot type appended the plot_types dict rather than the plot type itself, so index.html then tried to use that dict as a dictionary key.
Also copy the default list before appending. "res" is the shared variable-defaults dictionary and this loop runs once per web-data entry, so appending in place permanently modified the loaded defaults.
Verified with a plotting script registering plot_type "CloudRegimes": the tab now renders on index.html and the generated site has no broken internal links.