Normalize legacy optic source alias#17
Open
colonelpanic8 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opticsource value toopticalin sync and async source settersoptical, matching the README and testing utilityopticalias normalization and directopticalusageContext
I verified against an LS50 Wireless II on firmware V41190 that setting
kefPhysicalSourcetoopticis accepted by the API but does not switch the speaker into the Optical input. SettingkefPhysicalSourcetoopticalswitches correctly and reports the player metadata asserviceID: Optical.This keeps
opticworking as a backward-compatible alias for existing callers while sending the source value the speaker expects.Test
python -m unittest discover -s tests