Remove asyncio#14
Open
maclarel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up front - this isn't a super impactful PR. I was building out some scripting against Mythic and did an audit of imports and
asynciogot flagged as extraneous & potentially risky due to it being functionally obsolete. Keepingasynciois a no-op, but it's entirely unneeded at this point AFAICT.This PR drops "asyncio" from install_requires. It's the pre-3.4 stdlib backport, unused on any supported Python. Every asyncio.* call in mythic.py and mythic_utilities.py (TimeoutError, create_task, wait_for) resolves to the stdlib.
The PyPI package went dormant for years, then in Aug 2025 the maintainers republished it as an empty tombstone whose metadata literally says "Do not install this package." No version specifier on the current line means every fresh pip install mythic pulls that empty wheel.
Tested this locally by building a patched wheel, installed into a fresh 3.11 venv (no asyncio in the graph), imported cleanly, and ran a provisioning script against a live Mythic end-to-end. Behavior confirmed identical.