Revert "Merge pull request #64 from Mythetech/chore/net11-rc1" - #65
Merged
Conversation
Apollo cannot run on .NET 11: its analysis worker never initialises, so
diagnostics, error highlights and completions are gone ("J.suggestions is
not iterable" in the editor is the downstream symptom). Compilation and
execution still work because that path never constructs a Roslyn
workspace.
On single-threaded browser-wasm, .NET 11 makes SemaphoreSlim.Wait throw
PlatformNotSupportedException even when the semaphore is uncontended
(RuntimeFeature.ThrowIfMultithreadingIsNotSupported in
SemaphoreSlim.WaitCore). Roslyn's ProjectDependencyGraph takes exactly such
a wait on AdhocWorkspace.AddProject, so no Roslyn workspace can be created
in the browser at all. Upstream status:
- dotnet/runtime#131859: the runtime team calls the throw by design and
closed it; the guard is unchanged on release/11.0, so GA will not fix it.
- dotnet/roslyn#84615: open, no milestone; Roslyn considers removing its
blocking waits infeasible. Reproduces on Roslyn 5.3 and 5.6, so a Roslyn
bump does not help.
- Multithreaded WASM would avoid the guard, but WasmEnableThreads does not
start on .NET 11 (dotnet/runtime#131311, milestone Future) and GitHub
Pages cannot set the COOP/COEP headers it needs.
This reverts the whole upgrade so Apollo returns to the exact net10.0 tree
that was verified before it: Framework 0.18.1, the previous package set,
and the references the net10 base framework does not provide. Apollo stays
on .NET 10 until Roslyn or the runtime changes course.
Verified: 142 tests pass on the reverted tree, the client publishes, and
the analysis worker initialises without error in headless Chrome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.