Chore/framework upgrade - #62
Merged
Merged
Conversation
Apollo was on Mythetech.Framework 0.3.3 / WebAssembly 0.3.0. The jump to 0.18.1 brings MudBlazor 8.14 -> 9.3 transitively, which is where all the breaking changes came from. - Bump Microsoft.AspNetCore.Components.WebAssembly (and DevServer) plus Microsoft.Extensions.Configuration.FileExtensions to 10.0.5 to match the framework's floor and avoid an NU1605 downgrade error - Migrate the event viewer timeline off the removed MudTimeSeriesChart to the unified MudChart<T> with ChartType.Timeseries. TimeSeriesChartSeries is now ChartSeries<int>, AxisChartOptions folded into TimeSeriesChartOptions and the MatchBoundsToSize component parameter, and per-series line/area selection moved to SeriesDisplayOverrides - IDialogService.ShowMessageBox is now ShowMessageBoxAsync - MudBlazor's ToDescriptionString() enum extension is gone in v9
Dependabot needs a check on PRs it opens. static.yml already ran tests on pull_request, but it is the deploy pipeline and its test job is entangled with the Pages concurrency group, so give PRs their own workflow matching the one in Aion, Iris, and Siren. Also corrects setup-dotnet in static.yml, which asked for 9.0 while global.json pins SDK 10.0.100 with allowPrerelease false. That only worked because the runner image happened to ship a 10.x SDK.
Several Apollo types were upstreamed into Mythetech.Framework after Apollo pinned 0.3.3, and the framework versions have since gained fixes Apollo's forks never got. Now that Apollo is on 0.18.1, delete the local copies. - IRuntimeEnvironment and WebAssemblyRuntimeEnvironment: the framework ships both, plus AddRuntimeEnvironment(). Its interface adds a Platform member, and IsDevelopment/IsProduction compare case-insensitively rather than against lowercase literals - PlatformInfo: framework version adds IsWindows, IsLinux and GetMetaKeyName - ApolloNotificationBar and AddApolloNotification: framework's MythetechNotificationBar configures per-severity action and icon colors, a longer error duration, and a blurred background - ProgressCountdown (only used by the notification bar): framework version fixes truncation from integer division and marshals StateHasChanged - ApolloSwitch: identical to MtSwitch apart from MtSwitch honoring disabled and readonly state on the input element. This also removes 236 lines of M3 switch CSS from app.css that duplicated MtSwitch's scoped stylesheet; the settings-switch class keeps the full-width label/control spread that ApolloSwitch got from mud-width-full plus a MudSpacer
Comment on lines
+9
to
+31
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: 10.0.x | ||
|
|
||
| - name: Install .NET WASM workload | ||
| run: dotnet workload install wasm-tools | ||
|
|
||
| - name: Restore dependencies | ||
| run: dotnet restore | ||
|
|
||
| - name: Build | ||
| run: dotnet build --no-restore --configuration Release | ||
|
|
||
| - name: Unit tests | ||
| run: dotnet test Apollo.Test/Apollo.Test.csproj --no-build --configuration Release --verbosity normal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.