fix: improve SQLite clipboard history persistence#298
Closed
tingkai-c wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Please open an issue first before working on a PR since it ensures that an existing maintainer can explain how you should implement a feature, and also please explain why it would be an issue first. As for the code: Additionally, you did not mention the AI usage (again) and lacks any communication with the maintainers. For this reason I'm going to close this pull request. Please open an issue first to explain what you're trying to solve first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the reliability and startup behavior of SQLite-backed clipboard history.
The initial SQLite implementation loaded clipboard history synchronously before the launcher window could open. Histories containing large image blobs added database I/O and attempted image decoding to the startup path, making the launcher feel less snappy.
What Was Happening
Changes
user_versionMigration
Existing text and URL entries are preserved.
Legacy image entries cannot be recovered because they were stored as raw pixels without their dimensions. These invalid entries are removed during the one-time migration instead of continuing to occupy the history limit.
Testing
cargo +stable fmt --checkcargo +stable clippy --all-targets --all-featurescargo +stable test