Fix broken simhive include path in myochallenge left arm chain#3
Merged
Vittorio-Caggiano merged 1 commit intoJun 17, 2026
Conversation
handL_chain.xml lives in the same assets/ directory, so the ../../../../simhive/MPL_sim/assets/ prefix from the old submodule layout pointed nowhere once the package moved to pip distribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/left_arm_chain_myochallenge.xmlincludeshandL_chain.xmlvia a leftover submodule-style path (../../../../simhive/MPL_sim/assets/handL_chain.xml) that doesn't resolve once the package is consumed via pip (e.g.myo_sim/myosuite).handL_chain.xmllives in the sameassets/directory, so the include is simplified to a same-directory relative path, matching the fix already applied toarms_chain.xmlin PR fix: MuJoCo 3.x compat — remove convexhull, fix MPL_hand class, fix include paths #1.Test plan
mujoco.MjSpec.from_file("assets/left_arm_chain_myochallenge.xml")(or any model including it) resolves without missing-file errors