API: PUT /me/solving-times/{id} keeps the time's competition link - #205
Merged
Conversation
The PUT payload has no event field, but the processor dispatched EditPuzzleSolvingTime with competitionId: null and modify() assigns it unconditionally, so every API edit silently detached the time from its competition. Carry the current link through; the round link was never touched by modify() and stays intact. Refs #204 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QUegPi2i9SjwkcrNWyENnL
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PUT /api/v1/me/solving-times/{timeId}dispatchedEditPuzzleSolvingTimewithcompetitionId: null;EditPuzzleSolvingTimeHandler→PuzzleSolvingTime::modify()assigns the competition unconditionally, so every API edit silently detached the time from its event. The processor now carries the time's current competition through (it already loads the entity for the ownership check). The round link is never touched bymodify(), so it was — and stays — intact.Why a separate tiny PR
Live data-loss bug, 1-line fix; it ships ahead of the larger picker work tracked in #204 (PR 1 of 4).
Tests
UpdateSolvingTimeEndpointTest::testUpdateKeepsCompetitionAndRoundLink(PUT on a WJPC-linked fixture time keepscompetition_id+competition_round_id) — verified it fails onmain(nullvs the WJPC id) and passes here.Docs
docs/features/api/README.md: PUT never changes the event link.Refs #204
🤖 Generated with Claude Code
https://claude.ai/code/session_01QUegPi2i9SjwkcrNWyENnL