chore(theme): adopt the corrected canonical msn-shared.css - #1303
Merged
Merged
Conversation
.github#76 (aea21a38) corrected eleven tokens after measuring every text-token x surface-token pair in both modes; the canonical sha256 moved from b073e5e15bab to ee86c3d70b04. ci-conformance check 9 hashes this repo's copy against .github main and sits in ci-complete's needs:, so every stem PR from main was red until this landed. Verbatim re-copy, hash parity only: no repo-local edit to the file and no revert of the text-secondary substitutions from #1297. Fixes #1302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the corrected canonical
ui/theme/msn-shared.cssfromMustardSeedNetworks/.github(.github#76, commitaea21a38, merged2026-09-16T20:41Z). That change re-measured every text-token x
surface-token pair in both modes with
scripts/check-theme-contrast.pyrather than only against base and raised, and corrected eleven tokens —
including
--color-text-muted, which measured 4.38:1 on the sunken surfaceand is now
#5d6760at 4.57:1 on its worst ground.The canonical sha256 moved from
b073e5e15bab6366toee86c3d70b043389.ci-conformancecheck 9 hashes this repo's copy against.githubmain, andci-conformanceis inci-complete'sneeds:whileCI Completeisrequired — so no stem PR opened from main could merge until this landed.
This is a hash-parity re-copy and nothing else: no repo-local edit to
msn-shared.css, and no revert of thetext-secondarysubstitutions thatlanded with the previous adoption in #1297 (
SettingsDrawer.tsx:259,274,HelpDrawer.tsx:294are untouched). One file changed.Plan row: UI-STEM-17 (
stem-v1-plan.md, Phase 4d). Fleet row: UI-FLEET-3.Linked Issue
Fixes #1302
Type of Change
Chore — dependency/asset sync, no product behaviour change.
Risk
Low. A CSS custom-property file replaced by its upstream canonical; token
names are unchanged (
check-token-discipline.shgreen) so no consumer moves.The visible effect is eleven token values shifting to their measured-safe
equivalents. Contrast is verified two ways below.
Note for the next reader: a green Storybook a11y run is necessary but not
sufficient evidence about contrast. The previous adoption (#1297) recorded
that stories render on the addon's own backgrounds, not on
surface-hover,so the axe gate was green with an under-floor pair present. The
check-theme-contrast.pyrun below is the measurement that actually coversevery ground.
Testing Evidence
RED first —
ci-conformancecheck 9 on this branch before the copy, run with.githubmain's own script:GREEN after the copy, and hash parity with the canonical at
aea21a38:Full gate suite:
Repo
scripts/check-*— all 19, each run with its own interpreter:Security and Release Checklist
//nolintorbiome-ignoreaddedgovulncheck ./...clean