fix(ui): finish contextual help and keyboard tooltips - #1290
Merged
Merged
Conversation
krisarmstrong
enabled auto-merge
September 16, 2026 02:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finish page-specific help and keyboard tooltips throughout Stem. Header and sidebar Help now open the current route's test or glossary topic, restore keyboard focus, and close when browser history changes. Short help text is translated in English and Spanish; test details link to real standards and related tests, and glossary search reveals matching entries.
Unavailable actions expose their explanation on focus without executing or submitting. Enabled Help actions dismiss their tooltip after focusing the opener, so Escape closes the drawer reliably in WebKit. The local build also computes its embedded-UI hash after the frontend build instead of embedding the previous assets' hash.
Linked Issue
Fixes #1259
Fixes #1278
Fixes #1279
Fixes #1280
Fixes #1281
Fixes #1287
Type of Change
Risk
The tooltip conversion touches many form controls. Disabled-action mouse, Enter, Space and form-submission behavior is covered in a real Chromium story; page help is covered in Chromium and WebKit. Long technical guides remain in English according to the existing plan. No backend authorization policy or dependency changed.
Testing Evidence
make test: all 32 Go packages and frontend test files passed; Go coverage 78.6%.npm --prefix ui test: final full frontend suite557/557 passed in62files.npm --prefix ui run test:storybook:run: 111/111 browser component tests passed.E2E_SKIP_BUILD=1 scripts/run-e2e.sh e2e/help-context.spec.ts e2e/help-drawer-smoke.spec.ts e2e/help-drawer.spec.ts --workers=2: 24/24 passed, no retries or skips, against the built HTTPS daemon. English/Spanish, 390px/1440px, route topics, back/forward, trailing slashes, focus restoration and hover Escape.make build: frontend and backend passed. Both browser engines read/__version; its nonempty UI hash matched a separately calculated hash of the embedded assets.make lint,make fmt-check,npm --prefix ui run typecheck: no source lint/type/format violations. Existing golangci-lint unused-exclusion configuration warnings remain.make security: no Go vulnerabilities, npm vulnerabilities or secrets.node --test scripts/check-help-i18n.test.tsandnode scripts/check-help-i18n.ts: five fixtures and production consumer check passed. Sharedscripts/i18n/validate.shpassed; its existing notice about absent general extraction scripts remains. CI runs the concrete help consumer gate separately.Native Linux ARM64 validation in an Apple container on this Mac: C dataplane compilation, all five
go test ./internal/api/... -count=1 -timeout=180spackages, and CGO backend compilation passed as UID1000. Host-folder mounts failed with a virtualization error; sending a source archive over stdin allowed the isolated container to run. A separate root execution reproduced the existing reflector privilege-drop defect#1231 and is explicitly not a pass. This work does not claim real-packet or lab acceptance; hosted release packaging remains authoritative.Focused tooltip regressions:
./scripts/run-e2e.sh e2e/reflector-platform-guard.spec.ts e2e/rfc2544-subtest-selection.spec.ts --retries=0 --workers=2rebuilt the embedded UI and daemon, then passed all 8 tests on Chromium and WebKit. The tests assert disabled controls expose an accessible tooltip, Escape dismisses the tooltip before the drawer, and the selected RFC 2544 request payload remains unchanged. Biome passed both changed test files.Security and Release Checklist