Repository navigation
Realign functional-pass proteins before adding the reference - #1
Merged
Merged
Conversation
murrellb
marked this pull request as ready for review
October 6, 2026 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional-pass FASTA exports reused the screening alignment, so rejected ORFs and the screening aligner's gap choices continued to shape the exported proteins.
Build a fresh bundled MAFFT 7.520 FFT-NS-2 alignment from only the ungapped, passing, reference-trimmed proteins, then add the ungapped translated reference with MAFFT
--amino --add reference.fa passing-protein-alignment.fa. The sample alignment is the existing profile; the reference is the added sequence. Share arguments and sequence validation between browser and CLI, preserve terminal stop symbols, verify that reference addition preserves sample columns, and backtranslate gaps as complete codon triplets. Keep screening decisions and match annotations unchanged; avoid a second clipping that could remove terminal residues. Update the browser guide, README, methods, format documentation, and parity notes; rebuild the shipped CLI.Validation:
The reported manual 869-column alignment is not reproduced exactly by bundled FFT-NS-2. Its MAFFT version and exact command/options are needed to resolve that remaining difference; the implementation preserves every input residue, including terminal stops. Existing saved projects keep their stored alignments until collapse/functional filtering is recomputed.