馃懛 Align aggregate checks with closed pull request jobs - #477
Merged
Merged
Conversation
Assisted-by: GPT-5.6 via Codex
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃 AI text below 馃
Description
Allow the aggregate
馃殾 Checkjob to accept skipped test, lint, and templatejobs on
pull_request: closedevents.The producer jobs already skip closed pull requests, while the aggregate job
previously allowed skips only when change detection marked a job irrelevant.
After #476 merged, change detection correctly marked template CI as relevant,
the template job skipped because the event was
closed, and the aggregate jobincorrectly treated that skip as a failure in
run 30399676581.
The allowed-skip expressions now mirror the producer job conditions: tests,
lint, and templates may skip on closed events or when their path filters disable
them. Documentation remains unchanged because its closed-event path may remove
the pull request preview. Other pull request events, pushes, merge-group runs,
and manual runs continue to require every relevant job.
Validation
uvx prek run -agit diff --checkdocumentation cleanup path
The definitive hosted regression check is this pull request's own
closedrunafter merge.
Checklist
this change.
behavior change.
warnings.
If PR contains AI-assisted content:
Assisted-byfooter.content and accepts responsibility for it.