Skip to content

馃懛 Align aggregate checks with closed pull request jobs - #477

Merged
burgholzer merged 1 commit into
developfrom
agent/qdmi-closed-event-required-checks
Jul 29, 2026
Merged

burgholzer merged 1 commit into
developfrom
agent/qdmi-closed-event-required-checks

Conversation

@burgholzer

@burgholzer burgholzer commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

馃 AI text below 馃

Description

Allow the aggregate 馃殾 Check job to accept skipped test, lint, and template
jobs on pull_request: closed events.

The producer jobs already skip closed pull requests, while the aggregate job
previously allowed skips only when change detection marked a job irrelevant.
After #476 merged, change detection correctly marked template CI as relevant,
the template job skipped because the event was closed, and the aggregate job
incorrectly treated that skip as a failure in
run 30399676581.

The allowed-skip expressions now mirror the producer job conditions: tests,
lint, and templates may skip on closed events or when their path filters disable
them. Documentation remains unchanged because its closed-event path may remove
the pull request preview. Other pull request events, pushes, merge-group runs,
and manual runs continue to require every relevant job.

Validation

  • uvx prek run -a
  • git diff --check
  • Independent read-only review of the closed/non-closed event truth table and
    documentation cleanup path

The definitive hosted regression check is this pull request's own closed run
after merge.

Checklist

  • The pull request only contains commits that are focused and relevant to
    this change.
  • The workflow's existing aggregate gate covers the changed behavior.
  • Documentation changes are not required for this CI-only correction.
  • A changelog entry is not warranted because there is no user-facing
    behavior change.
  • Migration instructions are not needed.
  • The changes follow the project's style guidelines and introduce no new
    warnings.
  • The changes passed the relevant local validation listed above.
  • The code changes have been independently reviewed.

If PR contains AI-assisted content:

  • AI assistance is disclosed at the beginning of this description.
  • The AI-assisted commit includes the required Assisted-by footer.
  • A human maintainer has personally reviewed and understood all AI-assisted
    content and accepts responsibility for it.

@github-actions

github-actions Bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-29 12:47 UTC

@burgholzer burgholzer self-assigned this Jul 29, 2026
@burgholzer burgholzer added the continuous integration Changes related to CI/CD label Jul 29, 2026
@burgholzer
burgholzer marked this pull request as ready for review July 29, 2026 12:46
@burgholzer
burgholzer merged commit f07a319 into develop Jul 29, 2026
20 checks passed
@burgholzer
burgholzer deleted the agent/qdmi-closed-event-required-checks branch July 29, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration Changes related to CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant