Fix #811: Initialize Temporal configuration on server boot - #1077
Draft
venkatankkundavaram-dev wants to merge 2 commits into
Draft
Fix #811: Initialize Temporal configuration on server boot#1077venkatankkundavaram-dev wants to merge 2 commits into
venkatankkundavaram-dev wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initialize the Temporal client configuration as part of the Rails initializer so server processes have the configured host, port, namespace, and task queue before scheduling syncs.
Problem addressed
Issue #811 reports scheduled syncs failing with a gRPC hostname error even though the
TEMPORAL_*environment variables are present.server/config/initializers/temporal.rbdefinedTemporalService.setupbut did not invoke it during normal Rails initialization; setup was only invoked from Puma's worker boot callback and Temporal CLI paths.Technical approach
TemporalService.setupat the end of the existing Temporal Rails initializer.Files changed
server/config/initializers/temporal.rb— initialize Temporal during Rails boot.server/spec/initializers/temporal_spec.rb— regression coverage for host, port, namespace, and task queue configuration.Tests performed and results
Backward compatibility impact
Low. This uses the existing
TemporalService.setupimplementation and existing environment-variable defaults. It changes initialization timing so the same configuration is available to Rails server code immediately after boot.Related issue
Fixes #811
Limitations / follow-up work
Repository CI should confirm the initializer spec and server suite. If repeated setup during Puma worker boot proves undesirable, deduplicating the later setup call can be considered separately rather than expanding this bug fix's scope.