esdl time varying profile parsing#463
Conversation
MarkTNO
requested review from
FJanssen-TNO,
KobusVanRooyen and
jimrojerTNO
as code owners
MarkTNO
force-pushed
the
442-timeseries-fromto-postgres-option
branch
from
04e1933 to
008e25a
Compare
| from mesido.esdl.common import Asset | ||
| from mesido.esdl.esdl_additional_vars_mixin import get_asset_contraints | ||
| from mesido.esdl.profile_parser import InfluxDBProfileReader | ||
| from mesido.esdl.profile_parser import ESDLTimeVaryingProfileReader |
There was a problem hiding this comment.
Please change this name to something else. This name sounds like the profile is changing over time, in other words the profile is different per year. Anyway all the profiles in MESIDO xxx vs time. So no need to use time in the name anyway.
Even if you just take out the "Time"in the name
| from mesido.esdl.common import Asset | ||
| from mesido.esdl.esdl_additional_vars_mixin import get_asset_contraints | ||
| from mesido.esdl.profile_parser import InfluxDBProfileReader | ||
| from mesido.esdl.profile_parser import ESDLTimeVaryingProfileReader |
There was a problem hiding this comment.
Is there a way we can keep the old InfluxDBProfileReader in place and add the new ESDLTimeVaryingProfileReader and then we add a warning message to the terminal that InfluxDBProfileReader will be depreciated soon or by xxxx and that they should start using ESDLTimeVaryingProfileReader.
The reason for this is that we have other non-TNO people who also uses MESIDO locally. And this way we give them a warning at least.
|
@MarkTNO first review has been completed |
MarkTNO
force-pushed
the
442-timeseries-fromto-postgres-option
branch
2 times, most recently
from
e23c6a9 to
6d3b1c4
Compare
MarkTNO
force-pushed
the
442-timeseries-fromto-postgres-option
branch
from
6d3b1c4 to
9b2c0a4
Compare
MarkTNO
left a comment
MarkTNO
left a comment
There was a problem hiding this comment.
This now enables reading from and writing to multiple profile types.
The write_result_db_profiles parameter is removed.
The esdl_profiles_output_type determines the output profile type. None (default) will not create output profiles.
2 participants
No description provided.