Fix the scoreboard being blank when running CanvasMC#86
Closed
byPixelTV wants to merge 6 commits into
Closed
Conversation
|
I added these methods in this commit: Realistically speaking, this seemed easier than trying to reflect into the |
Dominilk01
reviewed
Jun 28, 2026
Dominilk01
reviewed
Jun 28, 2026
Author
|
I think this pullrequest can be closed because of #88. I have to admit that using internals of Canvas is not the best fix for this issue, even though it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using FastBoard for a while now. I primarily use Folia based servers which also includes Canvas. After updating to FastBoard 2.2.0 I've noticed that my scoreboard now looks like this.
Canvas rewrites and restores the scoreboard system, which was removed on Folia. Before FastBoard 2.2.0 this did not matter, because FastBoard only accessed methods and fields that are also available with the rewritten scoreboard system, so nothing broke.
This pr adds code to check if we are running on a Canvas server and uses methods introduced by Canvas to set the team display name, prefix and suffix so fastboard has full support for the rewritten scoreboard system.
References