Skip to content

BACK-555 - Match milestone ID queries in task list milestone filtering - #820

Draft
therealkevinard wants to merge 4 commits into
MrLesk:mainfrom
therealkevinard:tasks/back-555-milestone-id-filter
Draft

BACK-555 - Match milestone ID queries in task list milestone filtering#820
therealkevinard wants to merge 4 commits into
MrLesk:mainfrom
therealkevinard:tasks/back-555-milestone-id-filter

Conversation

@therealkevinard

Copy link
Copy Markdown

Track the milestone filter ID-lookup bug reported upstream as #819.

Summary

Briefly explain the purpose of this pull request.

Related Issue or Task

Link the issue or task this PR closes, e.g. closes #123 or closes task-29.

📋 Important: Please discuss the change in an issue before opening a PR.

  • If no issue exists, open one first so maintainers and contributors can agree that the proposal fits the current project scope before implementation.
  • All PRs must have an associated task in the backlog.
  • If no task exists, create one first using: backlog task create "Your task title"
  • Follow the task guidelines when creating tasks
  • Tasks should be atomic, testable, and well-defined with clear acceptance criteria

Task Checklist

  • I have created a corresponding task in backlog/tasks/
  • The task has clear acceptance criteria
  • I have added an implementation plan to the task
  • All acceptance criteria in the task are marked as completed

Testing

Describe how you tested your changes.

therealkevinard and others added 2 commits July 27, 2026 16:31
Track the milestone filter ID-lookup bug reported upstream as
MrLesk#819.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@therealkevinard
therealkevinard force-pushed the tasks/back-555-milestone-id-filter branch from 69d1c74 to 5bafe25 Compare July 27, 2026 20:56
therealkevinard and others added 2 commits July 27, 2026 17:02
The milestone query was passed raw into the closest-match step while
candidate values were resolved to titles, so the ID-to-title resolver
only ran on one side of the comparison. Filtering by a milestone ID
matched nothing, including the exact ID form stored on the task.

Resolve the query before matching in the CLI/JSON path and the MCP
draft list path. Add resolveMilestoneFilterTitle to resolve a query to
the stored milestone title, and use it to seed the interactive view,
which compares raw titles rather than the normalized form the CLI was
handing it. That also fixes milestone titles containing punctuation,
which is the same value-vocabulary defect and not separable from it.

Fixes MrLesk#819

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@therealkevinard

Copy link
Copy Markdown
Author

reporting collateral findings. plan was not to muddy this MR with side-work, but this is relevant as one of the findings was a breaking blocker for this change.

collateral-findings.md

and the fix that leaked in- Why this PR also fixes punctuated milestone titles:

The interactive list compares raw milestone titles, but the CLI was handing it a normalized value (Release-1release 1). So -m "Release-1" matched nothing there — same root cause as the ID bug, just a different input tripping it.
Both are the same one line in cli.ts. Making ID queries work in the interactive list requires handing it a real title, which fixes punctuated titles at the same time. Splitting them would have meant shipping ID lookups that only work for milestones whose titles happen to contain no punctuation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant