feat(vscode): show all agent questions in one form with multi-select support - #2466
feat(vscode): show all agent questions in one form with multi-select support#2466wbxl2000 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 7abe7b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7abe7b2c33
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| value={customText} | ||
| onChange={(e) => setCustomText(questionIdx, e.target.value, isMulti)} | ||
| onKeyDown={(e) => { | ||
| if (e.key === "Enter" && !e.nativeEvent.isComposing) void handleSubmit(); |
There was a problem hiding this comment.
Avoid submitting all questions from a custom field
When a request contains multiple questions and the user types a custom response for an earlier question, pressing Enter in this input immediately calls handleSubmit(), which sends the current partial answers and skips any remaining unanswered questions. In the new all-at-once form, Enter should only commit/close the current custom field or be ignored so users can finish the rest of the form before resolving the agent question.
Useful? React with 👍 / 👎.
|
Closing in favor of the direction taken by #2467 (step-through questions with back-navigation and explicit submission), which fixes the same multi-select limitation with an interaction model closer to the existing wizard. Thanks for the exploration here. |
Related Issue
Resolve #2463
Problem
The question dialog treated every question as single-select and stepped through questions one by one with no way back:
multi_selectquestions only captured the first clicked label, answered questions could not be changed, and individual questions could not be skipped even though partial answers are contract-legal.What changed
Reworked the question dialog from a step-through wizard into a single scrollable form, following the semantics the TUI already established:
', '(same convention as the TUI); a per-question custom text is appended as an extra label for multi-select, and wins over the chosen option for single-select.buildQuestionAnswers) so it is unit-tested without webview component test infra.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.