fix(agent-core): correct v1 Agent tool description to match 2-hour default timeout - #2450
Closed
C0d3N1nja97342 wants to merge 1 commit into
Closed
fix(agent-core): correct v1 Agent tool description to match 2-hour default timeout#2450C0d3N1nja97342 wants to merge 1 commit into
C0d3N1nja97342 wants to merge 1 commit into
Conversation
…fault timeout The v1 Agent tool description said subagents use a 'fixed 30-minute timeout', but DEFAULT_SUBAGENT_TIMEOUT_MS is 2 hours (subagent-host.ts). v2 was already aligned. Update the description to say 'configurable timeout that defaults to 2 hours' and mention the KIMI_SUBAGENT_TIMEOUT_MS / [subagent] timeout_ms config knobs. Update the test assertion to match the new text and add checks for the configurability note. Fixes MoonshotAI#2420
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #2420
Problem
The v1 Agent tool description (agent.md) told the model subagents use a 'fixed 30-minute timeout', but DEFAULT_SUBAGENT_TIMEOUT_MS is 2 hours. The word 'fixed' also hid that the timeout is configurable. v2 was already aligned.
What changed
Checklist