Fall Theme - #9
Closed
mauricemitchell318 wants to merge 5 commits into
Closed
mauricemitchell318 wants to merge 5 commits into
mauricemitchell318 wants to merge 5 commits into
Conversation
Added a new theme entry for 'Fall is here' with associated file.
I changed it from Fall Is Here to Fall is here to try to trigger the validator
❌ Validation failed
index.json is out of date
Run Expected index.json{
"schemaVersion": 1,
"themes": [
{
"id": "bluesneyplus",
"displayName": "BluesneyPlus",
"file": "themes/bluesneyplus.theme.json"
},
{
"id": "darkflix",
"displayName": "darkflix",
"description": "a netflix style theme",
"file": "themes/darkflix.theme.json"
},
{
"id": "fall_here",
"displayName": "Fall is here",
"file": "themes/fall_here.theme.json"
},
{
"id": "greenlu",
"displayName": "Greenlu",
"file": "themes/greenlu.theme.json"
},
{
"id": "midnight",
"displayName": "Midnight",
"description": "Deep navy dark theme with cyan accents.",
"file": "themes/midnight.theme.json"
},
{
"id": "purplemax",
"displayName": "Purple Max",
"file": "themes/purplemax.theme.json"
},
{
"id": "purplier",
"displayName": "Purplier",
"description": "A purplier purple, for purpliurs.",
"file": "themes/purplier.theme.json"
},
{
"id": "redflix",
"displayName": "Redflix",
"file": "themes/redflix.theme.json"
}
]
}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Provide a brief description of what this PR changes and why.
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
List the key changes included in this PR.
Checklist
<id>.theme.jsonand theidinside it matchesindex.jsonwas regenerated withnode scripts/generate-index.mjsnode scripts/validate-themes.mjspasses locallyScreenshots
Include a screenshot of the theme applied in a client.