Skip to content

Fall Theme - #9

Closed
mauricemitchell318 wants to merge 5 commits into
Moonfin-Client:mainfrom
mauricemitchell318:fall_here
Closed

mauricemitchell318 wants to merge 5 commits into
Moonfin-Client:mainfrom
mauricemitchell318:fall_here

Conversation

@mauricemitchell318

Copy link
Copy Markdown
Contributor

Pull Request

Summary

Provide a brief description of what this PR changes and why.

Related Issues

Link related issues or tickets separated by commas.

  • Closes #
  • Fixes #
  • Trying to get my theme validated
  • Related to #

Type of Change

  • [x ] New theme
  • Theme update
  • Tooling / CI change
  • Documentation update
  • Other (describe):

Changes Made

List the key changes included in this PR.

Checklist

  • The file is named <id>.theme.json and the id inside it matches
  • index.json was regenerated with node scripts/generate-index.mjs
  • node scripts/validate-themes.mjs passes locally
  • The theme was previewed in a Moonfin client

Screenshots

Include a screenshot of the theme applied in a client.

@github-actions

Copy link
Copy Markdown

❌ Validation failed

Check Status
Theme files ✅ Passed
index.json ❌ Failed

index.json is out of date

index.json is generated from the files in themes/, so a change to a theme has to bring the regenerated manifest with it.

Run node scripts/generate-index.mjs from the repository root and commit the result. Without Node on hand, copy the block below over index.json.

Expected index.json
{
  "schemaVersion": 1,
  "themes": [
    {
      "id": "bluesneyplus",
      "displayName": "BluesneyPlus",
      "file": "themes/bluesneyplus.theme.json"
    },
    {
      "id": "darkflix",
      "displayName": "darkflix",
      "description": "a netflix style theme",
      "file": "themes/darkflix.theme.json"
    },
    {
      "id": "fall_here",
      "displayName": "Fall is here",
      "file": "themes/fall_here.theme.json"
    },
    {
      "id": "greenlu",
      "displayName": "Greenlu",
      "file": "themes/greenlu.theme.json"
    },
    {
      "id": "midnight",
      "displayName": "Midnight",
      "description": "Deep navy dark theme with cyan accents.",
      "file": "themes/midnight.theme.json"
    },
    {
      "id": "purplemax",
      "displayName": "Purple Max",
      "file": "themes/purplemax.theme.json"
    },
    {
      "id": "purplier",
      "displayName": "Purplier",
      "description": "A purplier purple, for purpliurs.",
      "file": "themes/purplier.theme.json"
    },
    {
      "id": "redflix",
      "displayName": "Redflix",
      "file": "themes/redflix.theme.json"
    }
  ]
}
Property Value
Commit 4df455b
Workflow run Validate themes #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant